[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <61b0c6c7-e5ad-4cbf-a020-230d96d43d3e@ti.com>
Date: Tue, 9 Jan 2024 13:33:07 -0600
From: Andrew Davis <afd@...com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
Frank Binns
<frank.binns@...tec.com>,
Matt Coster <matt.coster@...tec.com>,
"H . Nikolaus
Schaller" <hns@...delico.com>,
Adam Ford <aford173@...il.com>,
Ivaylo
Dimitrov <ivo.g.dimitrov.75@...il.com>,
Maarten Lankhorst
<maarten.lankhorst@...ux.intel.com>,
Maxime Ripard <mripard@...nel.org>,
Thomas Zimmermann <tzimmermann@...e.de>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley
<conor+dt@...nel.org>, Chen-Yu Tsai <wens@...e.org>,
Jernej Skrabec
<jernej.skrabec@...il.com>,
Samuel Holland <samuel@...lland.org>,
BenoƮt Cousson <bcousson@...libre.com>,
Tony Lindgren
<tony@...mide.com>, Nishanth Menon <nm@...com>,
Vignesh Raghavendra
<vigneshr@...com>,
Tero Kristo <kristo@...nel.org>, Paul Cercueil
<paul@...pouillou.net>
CC: <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<dri-devel@...ts.freedesktop.org>, <linux-mips@...r.kernel.org>,
<linux-omap@...r.kernel.org>, <linux-sunxi@...ts.linux.dev>,
<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 01/11] dt-bindings: gpu: Rename img,powervr to
img,powervr-rogue
On 1/9/24 1:17 PM, Krzysztof Kozlowski wrote:
> On 09/01/2024 20:04, Andrew Davis wrote:
>> On 1/9/24 12:59 PM, Krzysztof Kozlowski wrote:
>>> On 09/01/2024 18:19, Andrew Davis wrote:
>>>> This binding will be used for GPUs starting from Series6 (Rogue)
>>>> and later. A different binding document will describe Series5.
>>>> With that the name "img,powervr" is too generic, rename to
>>>> "img,powervr-rogue" to avoid confusion.
>>>>
>>>> Suggested-by: Maxime Ripard <mripard@...nel.org>
>>>> Signed-off-by: Andrew Davis <afd@...com>
>>>> Reviewed-by: Javier Martinez Canillas <javierm@...hat.com>
>>>> Reviewed-by: Frank Binns <frank.binns@...tec.com>
>>>> ---
>>>
>>> Why do you send new version while we still talk about previous?
>>>
>>> Please implement feedback from v1 (and this is v2, so next is v3) or
>>> keep discussing.
>>>
>>
>> I agreed with everything you said in the last round (RFC v2) and
>> made all requested changes. Did I miss something in this version?
>
> The recommendation is that naming of the file matches generic compatible
> and your file has only one generic compatible. Therefore I don't
> understand why you claimed there are multiple compatibles.
>
I said "There are (or will be) multiple compatible strings", the rest
are on the way. So I didn't want to make this file less generic when
other bindings are almost ready.
Frank, can you help here, I'm assuming you have "img,img-bxs" and
"img,img-8xe" bindings staged for upstreaming somewhere; you'll be
putting those in this same file, right?
Thanks,
Andrew
> Best regards,
> Krzysztof
>
Powered by blists - more mailing lists