linux-kernel - [PATCH linux-next v2] drm/nouveau/disp: switch to use kmemdup() helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <202401091424115185126@zte.com.cn>
Date: Tue, 9 Jan 2024 14:24:11 +0800 (CST)
From: <yang.guang5@....com.cn>
To: <kherbst@...hat.com>
Cc: <jiang.xuexin@....com.cn>, <chen.haonan2@....com.cn>, <cgel.zte@...il.com>,
        <lyude@...hat.com>, <dakr@...hat.com>, <airlied@...il.com>,
        <daniel@...ll.ch>, <bskeggs@...hat.com>, <keescook@...omium.org>,
        <dri-devel@...ts.freedesktop.org>, <nouveau@...ts.freedesktop.org>,
        <linux-kernel@...r.kernel.org>
Subject: [PATCH linux-next v2] drm/nouveau/disp: switch to use kmemdup() helper

From: Chen Haonan <chen.haonan2@....com.cn>

Use kmemdup() helper instead of open-coding to
simplify the code.

Signed-off-by: Chen Haonan <chen.haonan2@....com.cn>
Reviewed-by: Yang Guang <yang.guang5@....com.cn>
---
 drivers/gpu/drm/nouveau/nvif/outp.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/nouveau/nvif/outp.c b/drivers/gpu/drm/nouveau/nvif/outp.c
index 5d3190c05250..6daeb7f0b09b 100644
--- a/drivers/gpu/drm/nouveau/nvif/outp.c
+++ b/drivers/gpu/drm/nouveau/nvif/outp.c
@@ -452,13 +452,12 @@ nvif_outp_edid_get(struct nvif_outp *outp, u8 **pedid)
 	if (ret)
 		goto done;

-	*pedid = kmalloc(args->size, GFP_KERNEL);
+	*pedid = kmemdup(args->data, args->size, GFP_KERNEL);
 	if (!*pedid) {
 		ret = -ENOMEM;
 		goto done;
 	}

-	memcpy(*pedid, args->data, args->size);
 	ret = args->size;
 done:
 	kfree(args);
-- 
2.25.1