linux-kernel - Re: [PATCH v2 2/2] gpu: drm: bridge: cadence: Add a driver and platform ops for StarFive JH7110 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fc30ce4736d43e367108c3651fec6f3b9a4d7852.camel@pengutronix.de>
Date: Tue, 09 Jan 2024 10:07:35 +0100
From: Philipp Zabel <p.zabel@...gutronix.de>
To: Shengyang Chen <shengyang.chen@...rfivetech.com>, 
	devicetree@...r.kernel.org, dri-devel@...ts.freedesktop.org
Cc: andrzej.hajda@...el.com, neil.armstrong@...aro.org, rfoss@...nel.org, 
 Laurent.pinchart@...asonboard.com, jonas@...boo.se,
 jernej.skrabec@...il.com,  maarten.lankhorst@...ux.intel.com,
 mripard@...nel.org, tzimmermann@...e.de,  airlied@...il.com,
 daniel@...ll.ch, robh+dt@...nel.org,  krzysztof.kozlowski+dt@...aro.org,
 conor+dt@...nel.org,  tomi.valkeinen@...asonboard.com, r-ravikumar@...com,
 aford173@...il.com,  rdunlap@...radead.org, u.kleine-koenig@...gutronix.de,
 bbrezillon@...nel.org,  changhuang.liang@...rfivetech.com,
 keith.zhao@...rfivetech.com,  jack.zhu@...rfivetech.com,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] gpu: drm: bridge: cadence: Add a driver and
 platform ops for StarFive JH7110 SoC

On Di, 2024-01-09 at 15:25 +0800, Shengyang Chen wrote:
> +static int cdns_dsi_get_reset(struct device *dev, struct cdns_dsi *dsi)
> +{
> +	dsi->dpi_rst = devm_reset_control_get(dev, "dpi");
> +	if (IS_ERR(dsi->dpi_rst))
> +		return PTR_ERR(dsi->dpi_rst);

Please use devm_reset_control_get_exclusive() directly.

Also, consider using devm_reset_control_bulk_get_exclusive() instead,
to control "dpi"/"apb"/"txesc" resets together - if the hardware can
handle deasserting in reversed order.

> +
> +	dsi->apb_rst = devm_reset_control_get(dev, "apb");
> +	if (IS_ERR(dsi->apb_rst))
> +		return PTR_ERR(dsi->apb_rst);
> +
> +	dsi->txesc_rst = devm_reset_control_get(dev, "txesc");
> +	if (IS_ERR(dsi->txesc_rst))
> +		return PTR_ERR(dsi->txesc_rst);
> +
> +	dsi->txbytehs_rst = devm_reset_control_get(dev, "txbytehs");
> +	if (IS_ERR(dsi->txbytehs_rst))
> +		return PTR_ERR(dsi->txbytehs_rst);
> +
> +	return 0;
> +}

regards
Philipp