linux-kernel - Re: [PATCH v2 10/15] dyndbg: add open and close commands for trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJfuBxxh7eF+DwMHvy_e6NsNEJ89R6Bqy8Mo5QF8qZwrMsSpgg@mail.gmail.com>
Date: Tue, 9 Jan 2024 08:19:35 -0700
From: jim.cromie@...il.com
To: Jason Baron <jbaron@...mai.com>
Cc: Łukasz Bartosik <lb@...ihalf.com>, 
	Andrew Morton <akpm@...ux-foundation.org>, Kees Cook <keescook@...omium.org>, 
	Douglas Anderson <dianders@...omium.org>, Guenter Roeck <groeck@...gle.com>, 
	Yaniv Tzoreff <yanivt@...gle.com>, Benson Leung <bleung@...gle.com>, 
	Steven Rostedt <rostedt@...dmis.org>, Vincent Whitchurch <vincent.whitchurch@...s.com>, 
	Pekka Paalanen <ppaalanen@...il.com>, Sean Paul <seanpaul@...omium.org>, 
	Daniel Vetter <daniel@...ll.ch>, linux-kernel@...r.kernel.org, upstream@...ihalf.com
Subject: Re: [PATCH v2 10/15] dyndbg: add open and close commands for trace

On Fri, Jan 5, 2024 at 3:46 PM Jason Baron <jbaron@...mai.com> wrote:
>
> On 11/30/23 6:40 PM, Łukasz Bartosik wrote:
> > Add open and close commands for opening and closing trace instances.
> > The open command has to be mandatory followed by a trace instance name.
> > If a trace instance already exists in <debugfs>/tracing/instances
> > directory then the open command will reuse it otherwise a new trace
> > instance with a name provided to the open will be created. Close
> > command closes previously opened trace instance. The close will
> > fail if a user tries to close non-existent trace instances or an
> > instance which was not previously opened.
> >
> > For example the following command will open (create or reuse existing)
> > trace instance located in <debugfs>/tracing/instances/usbcore:
> >
> >      echo "open usbcore" > <debugfs>/dynamic_debug/control
>
> Hi,
>
> I'm wondering why this needs to be part of dynamic debug? Can't we make
> trace instances via 'mkdir' and then use those from the dynamic debug side?
>

I believe thats what happens now -

open foo on already opened foo is not an error.
so if the instance is already created, it just gets used, without
clearing the buffer.
So it can integrate with externally admin'd tracebufs.

the open foo requirement means that we can validate foo,
and error properly if it is mis-spelled



> Thanks,
>
> -Jason
>
>