linux-kernel - Re: [PATCH 1/4] dt-bindings: reset: sophgo: support SG2042

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5f724f59-8643-4f30-8cfb-8e3213b50118@linaro.org>
Date: Tue, 9 Jan 2024 16:19:26 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Chen Wang <unicornxw@...il.com>, aou@...s.berkeley.edu,
 chao.wei@...hgo.com, conor@...nel.org, krzysztof.kozlowski+dt@...aro.org,
 palmer@...belt.com, paul.walmsley@...ive.com, robh+dt@...nel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-riscv@...ts.infradead.org, haijiao.liu@...hgo.com,
 xiaoguang.xing@...hgo.com, guoren@...nel.org, jszhang@...nel.org,
 inochiama@...look.com
Cc: Chen Wang <unicorn_wang@...look.com>
Subject: Re: [PATCH 1/4] dt-bindings: reset: sophgo: support SG2042

On 09/01/2024 10:16, Chen Wang wrote:
> From: Chen Wang <unicorn_wang@...look.com>
> 
> Add bindings for the reset generator on the SOPHGO SG2042 RISC-V SoC.
> 
> Signed-off-by: Chen Wang <unicorn_wang@...look.com>

..

> +#define RST_UART2			31
> +
> +#define RST_UART3			32

No need for blank line above UART3. If there is going to be new
version/resend, please fix it.

Anyway:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

---

This is an automated instruction, just in case, because many review tags
are being ignored. If you know the process, you can skip it (please do
not feel offended by me posting it here - no bad intentions intended).
If you do not know the process, here is a short explanation:

Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions, under or above your Signed-off-by tag. Tag is "received", when
provided in a message replied to you on the mailing list. Tools like b4
can help here. However, there's no need to repost patches *only* to add
the tags. The upstream maintainer will do that for tags received on the
version they apply.

https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577

Best regards,
Krzysztof