linux-kernel - Re: [PATCH] drm/ci: Add msm tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 9 Jan 2024 09:16:01 -0800
From: Abhinav Kumar <quic_abhinavk@...cinc.com>
To: Rob Clark <robdclark@...il.com>
CC: Rob Clark <robdclark@...omium.org>, <linux-arm-msm@...r.kernel.org>,
        open
 list <linux-kernel@...r.kernel.org>,
        <dri-devel@...ts.freedesktop.org>,
        Helen
 Koike <helen.koike@...labora.com>,
        Maxime Ripard <mripard@...nel.org>,
        Thomas
 Zimmermann <tzimmermann@...e.de>,
        <freedreno@...ts.freedesktop.org>
Subject: Re: [PATCH] drm/ci: Add msm tests



On 1/9/2024 7:31 AM, Rob Clark wrote:
> On Mon, Jan 8, 2024 at 6:13 PM Rob Clark <robdclark@...il.com> wrote:
>>
>> On Mon, Jan 8, 2024 at 2:58 PM Abhinav Kumar <quic_abhinavk@...cinc.com> wrote:
>>>
>>>
>>>
>>> On 1/8/2024 11:50 AM, Rob Clark wrote:
>>>> From: Rob Clark <robdclark@...omium.org>
>>>>
>>>> The msm tests should skip on non-msm hw, so I think it should be safe to
>>>> enable everywhere.
>>>>
>>>> Signed-off-by: Rob Clark <robdclark@...omium.org>
>>>> ---
>>>>    drivers/gpu/drm/ci/testlist.txt | 49 +++++++++++++++++++++++++++++++++
>>>>    1 file changed, 49 insertions(+)
>>>>
>>>
>>> I do see that all these tests use igt_msm_dev_open() to make sure it
>>> opens only the MSM card.
>>>
>>> But if igt_msm_dev_open() fails, I dont see a igt_require() on some of
>>> the tests to skip them. So how will it safely skip on non-msm HW?
>>>
>>> Unless i am missing something here ....
>>
>> hmm, at the time I added the initial msm tests, and
>> igt_msm_dev_open(), I verified that they skipped on intel.. but since
>> then I'd switched from intel to sc8280xp device for primary dev
>> device, so I'd need to re-test to remember how it works.  If these
>> aren't skipping on !msm, it is a bug
> 
> I double checked, these tests skip in drm_open_driver() with "No known
> gpu found for chipset flags 0x64 (msm)", so no problem to run them on
> all CI runners.
> 
> BR,
> -R
> 

Ack, thanks for checking


Reviewed-by: Abhinav Kumar <quic_abhinavk@...cinc.com>

> 
>> BR,
>> -R
>>
>>>> diff --git a/drivers/gpu/drm/ci/testlist.txt b/drivers/gpu/drm/ci/testlist.txt
>>>> index f82cd90372f4..eaeb751bb0ad 100644
>>>> --- a/drivers/gpu/drm/ci/testlist.txt
>>>> +++ b/drivers/gpu/drm/ci/testlist.txt
>>>> @@ -2910,3 +2910,52 @@ kms_writeback@...teback-invalid-parameters
>>>>    kms_writeback@...teback-fb-id
>>>>    kms_writeback@...teback-check-output
>>>>    prime_mmap_kms@...fer-sharing
>>>> +msm_shrink@...y-gpu-sanitycheck-8
>>>> +msm_shrink@...y-gpu-sanitycheck-32
>>>> +msm_shrink@...y-gpu-8
>>>> +msm_shrink@...y-gpu-32
>>>> +msm_shrink@...y-gpu-madvise-8
>>>> +msm_shrink@...y-gpu-madvise-32
>>>> +msm_shrink@...y-gpu-oom-8
>>>> +msm_shrink@...y-gpu-oom-32
>>>> +msm_shrink@...y-mmap-sanitycheck-8
>>>> +msm_shrink@...y-mmap-sanitycheck-32
>>>> +msm_shrink@...y-mmap-8
>>>> +msm_shrink@...y-mmap-32
>>>> +msm_shrink@...y-mmap-madvise-8
>>>> +msm_shrink@...y-mmap-madvise-32
>>>> +msm_shrink@...y-mmap-oom-8
>>>> +msm_shrink@...y-mmap-oom-32
>>>> +msm_shrink@...y-mmap-dmabuf-sanitycheck-8
>>>> +msm_shrink@...y-mmap-dmabuf-sanitycheck-32
>>>> +msm_shrink@...y-mmap-dmabuf-8
>>>> +msm_shrink@...y-mmap-dmabuf-32
>>>> +msm_shrink@...y-mmap-dmabuf-madvise-8
>>>> +msm_shrink@...y-mmap-dmabuf-madvise-32
>>>> +msm_shrink@...y-mmap-dmabuf-oom-8
>>>> +msm_shrink@...y-mmap-dmabuf-oom-32
>>>> +msm_mapping@...g
>>>> +msm_mapping@...fw
>>>> +msm_mapping@...dow
>>>> +msm_submitoverhead@...mitbench-10-bos
>>>> +msm_submitoverhead@...mitbench-10-bos-no-implicit-sync
>>>> +msm_submitoverhead@...mitbench-100-bos
>>>> +msm_submitoverhead@...mitbench-100-bos-no-implicit-sync
>>>> +msm_submitoverhead@...mitbench-250-bos
>>>> +msm_submitoverhead@...mitbench-250-bos-no-implicit-sync
>>>> +msm_submitoverhead@...mitbench-500-bos
>>>> +msm_submitoverhead@...mitbench-500-bos-no-implicit-sync
>>>> +msm_submitoverhead@...mitbench-1000-bos
>>>> +msm_submitoverhead@...mitbench-1000-bos-no-implicit-sync
>>>> +msm_recovery@...gcheck
>>>> +msm_recovery@...-fault
>>>> +msm_recovery@...-fault-parallel
>>>> +msm_recovery@...a-fault
>>>> +msm_submit@...ty-submit
>>>> +msm_submit@...alid-queue-submit
>>>> +msm_submit@...alid-flags-submit
>>>> +msm_submit@...alid-in-fence-submit
>>>> +msm_submit@...alid-duplicate-bo-submit
>>>> +msm_submit@...alid-cmd-idx-submit
>>>> +msm_submit@...alid-cmd-type-submit
>>>> +msm_submit@...id-submit