linux-kernel - Re: [PATCH v3 6/6] Makefile.extrawarn: turn on missing-prototypes globally

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ab94f844-a4ec-4b4f-b67b-2b67347596d9@roeck-us.net>
Date: Wed, 10 Jan 2024 11:45:16 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
	Arnd Bergmann <arnd@...db.de>,
	"David S. Miller" <davem@...emloft.net>,
	David Woodhouse <dwmw2@...radead.org>,
	Dinh Nguyen <dinguyen@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Ivan Kokshaysky <ink@...assic.park.msu.ru>,
	John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>,
	Michael Ellerman <mpe@...erman.id.au>,
	Masahiro Yamada <masahiroy@...nel.org>,
	Matt Turner <mattst88@...il.com>,
	Nathan Chancellor <nathan@...nel.org>,
	Nicolas Schier <nicolas@...sle.eu>,
	Peter Zijlstra <peterz@...radead.org>,
	Rich Felker <dalias@...c.org>,
	Richard Henderson <richard.henderson@...aro.org>,
	Richard Weinberger <richard@....at>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
	Tudor Ambarus <tudor.ambarus@...aro.org>,
	Yoshinori Sato <ysato@...rs.sourceforge.jp>,
	linux-arch@...r.kernel.org, linux-alpha@...r.kernel.org,
	linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-mips@...r.kernel.org, linux-mtd@...ts.infradead.org,
	linux-sh@...r.kernel.org, linux-usb@...r.kernel.org,
	sparclinux@...r.kernel.org, x86@...nel.org,
	Kees Cook <keescook@...omium.org>,
	Palmer Dabbelt <palmer@...osinc.com>
Subject: Re: [PATCH v3 6/6] Makefile.extrawarn: turn on missing-prototypes
 globally

On Thu, Nov 23, 2023 at 12:05:06PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> Over the years we went from > 1000 of warnings to under 100 earlier
> this year, and I sent patches to address all the ones that I saw with
> compile testing randcom configs on arm64, arm and x86 kernels. This is a
> really useful warning, as it catches real bugs when there are mismatched
> prototypes. In particular with kernel control flow integrity enabled,
> those are no longer allowed.
> 
> I have done extensive testing to ensure that there are no new build
> errors or warnings on any configuration of x86, arm and arm64 builds.
> I also made sure that at least the both the normal defconfig and an
> allmodconfig build is clean for arc, csky, loongarch, m68k, microblaze,
> openrisc, parisc, powerpc, riscv, s390, and xtensa, with the respective
> maintainers doing most of the patches.
> 
> At this point, there are five architectures with a number of known
> regressions: alpha, nios2, mips, sh and sparc. In the previous version
> of this patch, I had turned off the missing prototype warnings for the 15
> architectures that still had issues, but since there are only five left,
> I think we can leave the rest to the maintainers (Cc'd here) as well.
> 

Not sure I understand why this was so important that it warrants the
resulting buildtest failures.

FWIW, I'll disable WERROR in my build tests for the affected architectures.
That is kind of counter-productive, but the only real alternative would be
to stop build (and sometimes, such as for ppc, runtime) tests entirely,
which would be even worse.

Guenter