linux-kernel - Re: [PATCH v3 6/6] Makefile.extrawarn: turn on missing-prototypes globally

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <7a79c037-ac91-448a-b6e0-b38cacccd971@app.fastmail.com>
Date: Wed, 10 Jan 2024 21:43:40 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: "Guenter Roeck" <linux@...ck-us.net>, "Arnd Bergmann" <arnd@...nel.org>
Cc: "Andrew Morton" <akpm@...ux-foundation.org>,
 "David S . Miller" <davem@...emloft.net>,
 "David Woodhouse" <dwmw2@...radead.org>,
 "Dinh Nguyen" <dinguyen@...nel.org>,
 "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
 "Ivan Kokshaysky" <ink@...assic.park.msu.ru>,
 "John Paul Adrian Glaubitz" <glaubitz@...sik.fu-berlin.de>,
 "Michael Ellerman" <mpe@...erman.id.au>,
 "Masahiro Yamada" <masahiroy@...nel.org>,
 "Matt Turner" <mattst88@...il.com>,
 "Nathan Chancellor" <nathan@...nel.org>,
 "Nicolas Schier" <nicolas@...sle.eu>,
 "Peter Zijlstra" <peterz@...radead.org>, "Rich Felker" <dalias@...c.org>,
 "Richard Henderson" <richard.henderson@...aro.org>,
 "Richard Weinberger" <richard@....at>,
 "Stephen Rothwell" <sfr@...b.auug.org.au>,
 "Thomas Bogendoerfer" <tsbogend@...ha.franken.de>,
 "Tudor Ambarus" <tudor.ambarus@...aro.org>,
 "Yoshinori Sato" <ysato@...rs.sourceforge.jp>,
 Linux-Arch <linux-arch@...r.kernel.org>, linux-alpha@...r.kernel.org,
 linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-mips@...r.kernel.org, linux-mtd@...ts.infradead.org,
 linux-sh@...r.kernel.org, linux-usb@...r.kernel.org,
 sparclinux@...r.kernel.org, x86@...nel.org,
 "Kees Cook" <keescook@...omium.org>,
 "Palmer Dabbelt" <palmer@...osinc.com>
Subject: Re: [PATCH v3 6/6] Makefile.extrawarn: turn on missing-prototypes globally

On Wed, Jan 10, 2024, at 20:45, Guenter Roeck wrote:
> On Thu, Nov 23, 2023 at 12:05:06PM +0100, Arnd Bergmann wrote:
>> At this point, there are five architectures with a number of known
>> regressions: alpha, nios2, mips, sh and sparc. In the previous version
>> of this patch, I had turned off the missing prototype warnings for the 15
>> architectures that still had issues, but since there are only five left,
>> I think we can leave the rest to the maintainers (Cc'd here) as well.
>> 
>
> Not sure I understand why this was so important that it warrants the
> resulting buildtest failures.
>
> FWIW, I'll disable WERROR in my build tests for the affected architectures.
> That is kind of counter-productive, but the only real alternative would be
> to stop build (and sometimes, such as for ppc, runtime) tests entirely,
> which would be even worse.

If you prefer, I can go back to the older version and just disable
the warning for the architectures with defconfig build failures. I did
a lot of fixes for mips, so at least defconfig and allmodconfig
should be fine now, leaving only alpha, nios2, sh and sparc as
far as I can tell, at least once Linus merges the asm-generic
pull request hat has a bunch of the currently missing fixes.

   Arnd