linux-kernel - RE: [PATCH V12 1/7] x86: Drop CPU_SUP_INTEL from SCHED_MC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 10 Jan 2024 06:59:25 +0000
From: "Meng, Li (Jassmine)" <Li.Meng@....com>
To: Borislav Petkov <bp@...en8.de>
CC: "Rafael J . Wysocki" <rafael.j.wysocki@...el.com>, "Huang, Ray"
	<Ray.Huang@....com>, "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"x86@...nel.org" <x86@...nel.org>, "linux-acpi@...r.kernel.org"
	<linux-acpi@...r.kernel.org>, Shuah Khan <skhan@...uxfoundation.org>,
	"linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>,
	"Fontenot, Nathan" <Nathan.Fontenot@....com>, "Sharma, Deepak"
	<Deepak.Sharma@....com>, "Deucher, Alexander" <Alexander.Deucher@....com>,
	"Limonciello, Mario" <Mario.Limonciello@....com>, "Huang, Shimmer"
	<Shimmer.Huang@....com>, "Yuan, Perry" <Perry.Yuan@....com>, "Du, Xiaojian"
	<Xiaojian.Du@....com>, Viresh Kumar <viresh.kumar@...aro.org>, Oleksandr
 Natalenko <oleksandr@...alenko.name>
Subject: RE: [PATCH V12 1/7] x86: Drop CPU_SUP_INTEL from SCHED_MC_PRIO for
 the expansion.

[AMD Official Use Only - General]

Hi Petkov:

> -----Original Message-----
> From: Borislav Petkov <bp@...en8.de>
> Sent: Tuesday, January 9, 2024 6:45 PM
> To: Meng, Li (Jassmine) <Li.Meng@....com>
> Cc: Rafael J . Wysocki <rafael.j.wysocki@...el.com>; Huang, Ray
> <Ray.Huang@....com>; linux-pm@...r.kernel.org; linux-
> kernel@...r.kernel.org; x86@...nel.org; linux-acpi@...r.kernel.org; Shuah
> Khan <skhan@...uxfoundation.org>; linux-kselftest@...r.kernel.org;
> Fontenot, Nathan <Nathan.Fontenot@....com>; Sharma, Deepak
> <Deepak.Sharma@....com>; Deucher, Alexander
> <Alexander.Deucher@....com>; Limonciello, Mario
> <Mario.Limonciello@....com>; Huang, Shimmer
> <Shimmer.Huang@....com>; Yuan, Perry <Perry.Yuan@....com>; Du,
> Xiaojian <Xiaojian.Du@....com>; Viresh Kumar <viresh.kumar@...aro.org>;
> Oleksandr Natalenko <oleksandr@...alenko.name>
> Subject: Re: [PATCH V12 1/7] x86: Drop CPU_SUP_INTEL from
> SCHED_MC_PRIO for the expansion.
>
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
>
>
> On Tue, Dec 05, 2023 at 02:35:31PM +0800, Meng Li wrote:
> > amd-pstate driver also uses SCHED_MC_PRIO, so decouple the
> requirement
> > of CPU_SUP_INTEL from the dependencies to allow compilation in kernels
> > without Intel CPU support.
> >
> > Tested-by: Oleksandr Natalenko <oleksandr@...alenko.name>
> > Reviewed-by: Mario Limonciello <mario.limonciello@....com>
> > Reviewed-by: Huang Rui <ray.huang@....com>
> > Reviewed-by: Perry Yuan <perry.yuan@....com>
> > Signed-off-by: Meng Li <li.meng@....com>
> > ---
> >  arch/x86/Kconfig | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index
> > 3762f41bb092..3e57773f946a 100644
> > --- a/arch/x86/Kconfig
> > +++ b/arch/x86/Kconfig
> > @@ -1054,8 +1054,9 @@ config SCHED_MC
> >
> >  config SCHED_MC_PRIO
> >       bool "CPU core priorities scheduler support"
> > -     depends on SCHED_MC && CPU_SUP_INTEL
> > -     select X86_INTEL_PSTATE
> > +     depends on SCHED_MC
> > +     select X86_INTEL_PSTATE if CPU_SUP_INTEL
> > +     select X86_AMD_PSTATE if CPU_SUP_AMD && ACPI
> >       select CPU_FREQ
> >       default y
> >       help
> > --
>
> I was gonna ask why the selects but apparently mingo wants
> SCHED_MC_PRIO to be selectable easier:
>
> 0a21fc1214a2 ("sched/x86: Make CONFIG_SCHED_MC_PRIO=y easier to
> enable")
>
[Meng, Li (Jassmine)] Thank you for your feedback.
The reason why I added the selects is just to distinguish different pstate drivers.
These two drivers cannot be supported simultaneously in the same project.
> So,
>
> Acked-by: Borislav Petkov (AMD) <bp@...en8.de>
>
> Thx.
>
> --
> Regards/Gruss,
>     Boris.
>
> https://people.kernel.org/tglx/notes-about-netiquette