linux-kernel - Re: [PATCH v3] staging: vt6655: fix open parentheses alignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9fdcb306-862f-4ad5-a52f-cd70fd21cf05@infradead.org>
Date: Tue, 9 Jan 2024 23:56:30 -0800
From: Randy Dunlap <rdunlap@...radead.org>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Matthias Yee <mgyee9@...il.com>, gregkh@...uxfoundation.org,
 linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] staging: vt6655: fix open parentheses alignment



On 1/9/24 23:51, Dan Carpenter wrote:
> On Tue, Jan 09, 2024 at 11:30:17PM -0800, Randy Dunlap wrote:
>>> diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
>>> index 36183f2a64c1..688c870d89bc 100644
>>> --- a/drivers/staging/vt6655/card.c
>>> +++ b/drivers/staging/vt6655/card.c
>>> @@ -81,9 +81,9 @@ static void vt6655_mac_set_bb_type(void __iomem *iobase, u32 mask)
>>>   * Return Value: none
>>>   */
>>>  static void calculate_ofdmr_parameter(unsigned char rate,
>>> -				       u8 bb_type,
>>> -				       unsigned char *tx_rate,
>>> -				       unsigned char *rsv_time)
>>> +				      u8 bb_type,
>>> +				      unsigned char *tx_rate,
>>> +				      unsigned char *rsv_time)
>>>  {
>>>  	switch (rate) {
>>>  	case RATE_6M:
>>
>> Is there any chance that checkpatch is wrong about this warning?
>>
>> I much prefer the alignment as it was before this patch: following lines
>> are aligned with the first parameter after the '('.
>>
> 
> It just looks weird in the diff because of the + character at the front
> and how the tabs work out.  It looks ok in the code.

Oops, sorry, you are correct. Thanks!

-- 
#Randy