linux-kernel - RE: Re: [PATCH 3/3] ASoC: dt-bindings: fsl,micfil: Add compatible string for i.MX95 platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <DB9PR04MB9498CE3DD725B05EEAFE617FE3692@DB9PR04MB9498.eurprd04.prod.outlook.com>
Date: Wed, 10 Jan 2024 09:09:45 +0000
From: Chancel Liu <chancel.liu@....com>
To: Daniel Baluta <daniel.baluta@...il.com>
CC: "lgirdwood@...il.com" <lgirdwood@...il.com>, "broonie@...nel.org"
	<broonie@...nel.org>, "robh+dt@...nel.org" <robh+dt@...nel.org>,
	"krzysztof.kozlowski+dt@...aro.org" <krzysztof.kozlowski+dt@...aro.org>,
	"conor+dt@...nel.org" <conor+dt@...nel.org>, "shengjiu.wang@...il.com"
	<shengjiu.wang@...il.com>, "Xiubo.Lee@...il.com" <Xiubo.Lee@...il.com>,
	"festevam@...il.com" <festevam@...il.com>, "nicoleotsuka@...il.com"
	<nicoleotsuka@...il.com>, "perex@...ex.cz" <perex@...ex.cz>, "tiwai@...e.com"
	<tiwai@...e.com>, "linux-sound@...r.kernel.org"
	<linux-sound@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "alsa-devel@...a-project.org"
	<alsa-devel@...a-project.org>, "linuxppc-dev@...ts.ozlabs.org"
	<linuxppc-dev@...ts.ozlabs.org>
Subject: RE: Re: [PATCH 3/3] ASoC: dt-bindings: fsl,micfil: Add compatible
 string for i.MX95 platform

> On Tue, Jan 9, 2024 at 9:58 AM Chancel Liu <chancel.liu@....com> wrote:
> >
> > Add compatible string "fsl,imx95-micfil" for i.MX95 platform.
> >
> > Signed-off-by: Chancel Liu <chancel.liu@....com>
> > ---
> >  .../devicetree/bindings/sound/fsl,micfil.yaml     | 15 +++++++++++----
> >  1 file changed, 11 insertions(+), 4 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/sound/fsl,micfil.yaml
> b/Documentation/devicetree/bindings/sound/fsl,micfil.yaml
> > index b7e605835639..f0d3d11d07d2 100644
> > --- a/Documentation/devicetree/bindings/sound/fsl,micfil.yaml
> > +++ b/Documentation/devicetree/bindings/sound/fsl,micfil.yaml
> > @@ -15,10 +15,17 @@ description: |
> >
> >  properties:
> >    compatible:
> > -    enum:
> > -      - fsl,imx8mm-micfil
> > -      - fsl,imx8mp-micfil
> > -      - fsl,imx93-micfil
> > +    oneOf:
> > +      - items:
> > +          - enum:
> > +              - fsl,imx95-micfil
> > +          - const: fsl,imx93-micfil
> > +
> > +      - items:
> > +          - enum:
> > +              - fsl,imx8mm-micfil
> > +              - fsl,imx8mp-micfil
> > +              - fsl,imx93-micfil
> 
> My yaml knowledge is very limited. Can you describe in natural
> language in the commit what exactly we are doing here.
> 
> Why something like this:
> 
> 
> >    compatible:
> >     enum:
> >       - fsl,imx8mm-micfil
> >       - fsl,imx8mp-micfil
> >       - fsl,imx93-micfil
> +        - fsl,imx95-micfil
> 
> Isn't enough?

No. This shows MICFIL on i.MX95 is different from it on I.MX93.

However i.MX95 MICFIL is compatible with i.MX93 MICFIL.
The DT node of MICFIL on i.MX95 looks like:
micfil: micfil@...20000 {
	compatible = "fsl,imx95-micfil", "fsl,imx93-micfil";
	...
};

Regards, 
Chancel Liu