linux-kernel - Re: [PATCH] drm/ci: Add msm tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAF6AEGuXi1wTbE0j6FmSnqw_EVUYSdnk5WeFL6abD=zeNutPpg@mail.gmail.com>
Date: Fri, 12 Jan 2024 09:14:24 -0800
From: Rob Clark <robdclark@...il.com>
To: Vignesh Raman <vignesh.raman@...labora.com>
Cc: dri-devel@...ts.freedesktop.org, Rob Clark <robdclark@...omium.org>, 
	Daniel Vetter <daniel@...ll.ch>, linux-arm-msm@...r.kernel.org, 
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, 
	open list <linux-kernel@...r.kernel.org>, Maxime Ripard <mripard@...nel.org>, 
	Helen Koike <helen.koike@...labora.com>, Thomas Zimmermann <tzimmermann@...e.de>, 
	David Airlie <airlied@...il.com>, freedreno@...ts.freedesktop.org, 
	Daniel Stone <daniel@...ishbar.org>
Subject: Re: [PATCH] drm/ci: Add msm tests

On Fri, Jan 12, 2024 at 7:57 AM Rob Clark <robdclark@...il.com> wrote:
>
> On Fri, Jan 12, 2024 at 3:42 AM Vignesh Raman
> <vignesh.raman@...labora.com> wrote:
> >
> > Hi Rob,
> >
> >
> > On 09/01/24 01:20, Rob Clark wrote:
> > > From: Rob Clark <robdclark@...omium.org>
> > >
> > > The msm tests should skip on non-msm hw, so I think it should be safe to
> > > enable everywhere.
> > >
> > > Signed-off-by: Rob Clark <robdclark@...omium.org>
> > > ---
> > >   drivers/gpu/drm/ci/testlist.txt | 49 +++++++++++++++++++++++++++++++++
> > >   1 file changed, 49 insertions(+)
> > >
> > > diff --git a/drivers/gpu/drm/ci/testlist.txt b/drivers/gpu/drm/ci/testlist.txt
> > > index f82cd90372f4..eaeb751bb0ad 100644
> > > --- a/drivers/gpu/drm/ci/testlist.txt
> > > +++ b/drivers/gpu/drm/ci/testlist.txt
> > > @@ -2910,3 +2910,52 @@ kms_writeback@...teback-invalid-parameters
> > >   kms_writeback@...teback-fb-id
> > >   kms_writeback@...teback-check-output
> > >   prime_mmap_kms@...fer-sharing
> > > +msm_shrink@...y-gpu-sanitycheck-8
> > > +msm_shrink@...y-gpu-sanitycheck-32
> > > +msm_shrink@...y-gpu-8
> > > +msm_shrink@...y-gpu-32
> > > +msm_shrink@...y-gpu-madvise-8
> > > +msm_shrink@...y-gpu-madvise-32
> > > +msm_shrink@...y-gpu-oom-8
> > > +msm_shrink@...y-gpu-oom-32
> > > +msm_shrink@...y-mmap-sanitycheck-8
> > > +msm_shrink@...y-mmap-sanitycheck-32
> > > +msm_shrink@...y-mmap-8
> > > +msm_shrink@...y-mmap-32
> > > +msm_shrink@...y-mmap-madvise-8
> > > +msm_shrink@...y-mmap-madvise-32
> > > +msm_shrink@...y-mmap-oom-8
> > > +msm_shrink@...y-mmap-oom-32
> > > +msm_shrink@...y-mmap-dmabuf-sanitycheck-8
> > > +msm_shrink@...y-mmap-dmabuf-sanitycheck-32
> > > +msm_shrink@...y-mmap-dmabuf-8
> > > +msm_shrink@...y-mmap-dmabuf-32
> > > +msm_shrink@...y-mmap-dmabuf-madvise-8
> > > +msm_shrink@...y-mmap-dmabuf-madvise-32
> > > +msm_shrink@...y-mmap-dmabuf-oom-8
> > > +msm_shrink@...y-mmap-dmabuf-oom-32
> > > +msm_mapping@...g
> > > +msm_mapping@...fw
> > > +msm_mapping@...dow
> > > +msm_submitoverhead@...mitbench-10-bos
> > > +msm_submitoverhead@...mitbench-10-bos-no-implicit-sync
> > > +msm_submitoverhead@...mitbench-100-bos
> > > +msm_submitoverhead@...mitbench-100-bos-no-implicit-sync
> > > +msm_submitoverhead@...mitbench-250-bos
> > > +msm_submitoverhead@...mitbench-250-bos-no-implicit-sync
> > > +msm_submitoverhead@...mitbench-500-bos
> > > +msm_submitoverhead@...mitbench-500-bos-no-implicit-sync
> > > +msm_submitoverhead@...mitbench-1000-bos
> > > +msm_submitoverhead@...mitbench-1000-bos-no-implicit-sync
> > > +msm_recovery@...gcheck
> > > +msm_recovery@...-fault
> > > +msm_recovery@...-fault-parallel
> > > +msm_recovery@...a-fault
> > > +msm_submit@...ty-submit
> > > +msm_submit@...alid-queue-submit
> > > +msm_submit@...alid-flags-submit
> > > +msm_submit@...alid-in-fence-submit
> > > +msm_submit@...alid-duplicate-bo-submit
> > > +msm_submit@...alid-cmd-idx-submit
> > > +msm_submit@...alid-cmd-type-submit
> > > +msm_submit@...id-submit
> >
> > I tested this patch with latest drm-misc/drm-misc-next and there was
> > some failures seen for the newly added msm tests. I have updated the
> > xfails with below commit,
> >
> > https://gitlab.freedesktop.org/vigneshraman/linux/-/commit/d012893597a661d6ebbb755bf2607dfb055524a1
> >
> > I will notify the maintainers about the flaky tests, update the url in
> > the flakes.txt, and submit a separate patch for this change.

Oh, you should probably move msm_mapping@* to skips on sdm845.  I had
a closer look at those, and they are failing due to a bootloader/fw
issue.  We work around this in mesa CI with these two patches:

https://gitlab.freedesktop.org/gfx-ci/linux/-/commit/4b49f902ec6f2bb382cbbf489870573f4b43371e
https://gitlab.freedesktop.org/gfx-ci/linux/-/commit/38cdf4c5559771e2474ae0fecef8469f65147bc1

But given that sdm845 is similar to sc7180 as far as kernel gpu
driver, it is probably just better to skip these on sdm845 (with a
comment referring to the hack patches we use in mesa CI)

BR,
-R

>
> Thanks, it looks like you also have a relatively recent igt (there
> were some msm_submit fails until I fixed the test)..
>
> BR,
> -R
>
> > Regards,
> > Vignesh