linux-kernel - Re: [PATCH v4 3/4] pinctrl: renesas: pinctrl-rzg2l: Add the missing port pins P19 to P28

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 12 Jan 2024 17:14:46 +0000
From: "Lad, Prabhakar" <prabhakar.csengg@...il.com>
To: Biju Das <biju.das.jz@...renesas.com>
Cc: Geert Uytterhoeven <geert+renesas@...der.be>, Magnus Damm <magnus.damm@...il.com>, 
	Linus Walleij <linus.walleij@...aro.org>, Rob Herring <robh+dt@...nel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>, 
	"linux-renesas-soc@...r.kernel.org" <linux-renesas-soc@...r.kernel.org>, 
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, 
	"linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>, 
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, 
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>, 
	Claudiu Beznea <claudiu.beznea.uj@...renesas.com>, 
	Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: Re: [PATCH v4 3/4] pinctrl: renesas: pinctrl-rzg2l: Add the missing
 port pins P19 to P28

On Fri, Jan 12, 2024 at 5:10 PM Biju Das <biju.das.jz@...renesas.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Lad, Prabhakar <prabhakar.csengg@...il.com>
> > Sent: Friday, January 12, 2024 5:06 PM
> > Subject: Re: [PATCH v4 3/4] pinctrl: renesas: pinctrl-rzg2l: Add the
> > missing port pins P19 to P28
> >
> > Hi Biju,
> >
> > Thank you for the review.
> >
> > On Fri, Jan 12, 2024 at 2:31 PM Biju Das <biju.das.jz@...renesas.com>
> > wrote:
> > >
> > >
> > > Hi Prabhakar,
> > >
> > > > -----Original Message-----
> > > > From: Prabhakar <prabhakar.csengg@...il.com>
> > > > Sent: Friday, January 12, 2024 2:26 PM
> > > > Subject: [PATCH v4 3/4] pinctrl: renesas: pinctrl-rzg2l: Add the
> > > > missing port pins P19 to P28
> > > >
> > <snip>
> > > >
> > > > +/**
> > > > + * struct rzg2l_variable_pin_cfg - pin data cfg
> > > > + * @cfg: port pin configuration
> > > > + * @port: port number
> > > > + * @pin: port pin
> > > > + */
> > > > +struct rzg2l_variable_pin_cfg {
> > > > +     u32 cfg:20;
> > > > +     u8 port:5;
> > >
> > >  u32 ??
> > This is done based on the feedback provided previously by Geert [0].
> >
> > > > +     u8 pin:5;
> > >
> > >  u32 ??
> > >
> > ditto.
> >
>
> As per[0] suggestion is,
>
> As cfg only contains the lower bits (PIN_CFG_*), I think you can fit
> everything in a u32:
>
>     u32 cfg: 20;
>     u32 port: 5;
>     u32 pin: 3;
>
Ouch my bad, i'll send a v5 with this change.

Cheers,
Prabhakar