linux-kernel - RE: [PATCH 01/12] selftests/net: Add TCP-AO library

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 12 Jan 2024 18:02:02 +0000
From: "Nassiri, Mohammad" <mnassiri@...na.com>
To: Dmitry Safonov <dima@...sta.com>, Shuah Khan <shuah@...nel.org>,
        David
 Ahern <dsahern@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric
 Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni
	<pabeni@...hat.com>
CC: Salam Noureddine <noureddine@...sta.com>,
        Bob Gilligan
	<gilligan@...sta.com>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>,
        "linux-kselftest@...r.kernel.org"
	<linux-kselftest@...r.kernel.org>,
        "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>,
        Dmitry Safonov <0x7f454c46@...il.com>
Subject: RE: [PATCH 01/12] selftests/net: Add TCP-AO library

Hi Dmitry,

First, thank you for submitting this very helpful set of tcp-ao selftests!

>-----Original Message-----
>From: Dmitry Safonov <dima@...sta.com>
>Sent: Thursday, December 14, 2023 9:36 PM
>To: Shuah Khan <shuah@...nel.org>; David Ahern <dsahern@...nel.org>;
>David S. Miller <davem@...emloft.net>; Eric Dumazet
><edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo Abeni
><pabeni@...hat.com>
>Cc: Dmitry Safonov <dima@...sta.com>; Salam Noureddine
><noureddine@...sta.com>; Bob Gilligan <gilligan@...sta.com>; linux-
>kernel@...r.kernel.org; linux-kselftest@...r.kernel.org;
>netdev@...r.kernel.org; Dmitry Safonov <0x7f454c46@...il.com>
>Subject: [PATCH 01/12] selftests/net: Add TCP-AO library
>
>Provide functions to create selftests dedicated to TCP-AO.
>They can run in parallel, as they use temporary net namespaces.
>They can be very specific to the feature being tested.
>This will allow to create a lot of TCP-AO tests, without complicating
>one binary with many --options and to create scenarios, that are
>hard to put in bash script that uses one binary.
>
>Signed-off-by: Dmitry Safonov <dima@...sta.com>


>+	key_dump[0].nkeys = nr_keys;
>+	key_dump[0].get_all = 1;
>+	key_dump[0].get_all = 1;

Duplicate assignment of get_all.

>+	err = getsockopt(sk, IPPROTO_TCP, TCP_AO_GET_KEYS,
>+			 key_dump, &key_dump_sz);
>+	if (err) {
>+		free(key_dump);
>+		return -errno;
>+	}
>+}
>+
>+const struct sockaddr_in6 addr_any6 = {
>+	.sin6_family	= AF_INET6,
>+};
>+
>+const struct sockaddr_in addr_any4 = {
>+	.sin_family	= AF_INET,
>+};
>
>--
>2.43.0

Mohammad