linux-kernel - RE: [PATCH 12/12] selftests/net: Add TCP-AO key-management test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: 
 <DM6PR04MB4202DA43D14985A28055CE0FC56F2@DM6PR04MB4202.namprd04.prod.outlook.com>
Date: Fri, 12 Jan 2024 18:57:36 +0000
From: "Nassiri, Mohammad" <mnassiri@...na.com>
To: Dmitry Safonov <dima@...sta.com>, Shuah Khan <shuah@...nel.org>,
        David
 Ahern <dsahern@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric
 Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni
	<pabeni@...hat.com>
CC: Salam Noureddine <noureddine@...sta.com>,
        Bob Gilligan
	<gilligan@...sta.com>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>,
        "linux-kselftest@...r.kernel.org"
	<linux-kselftest@...r.kernel.org>,
        "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>,
        Dmitry Safonov <0x7f454c46@...il.com>
Subject: RE: [PATCH 12/12] selftests/net: Add TCP-AO key-management test

>-----Original Message-----
>From: Dmitry Safonov <dima@...sta.com>
>Sent: Thursday, December 14, 2023 9:36 PM

>+
>+static void end_server(const char *tst_name, int sk,
>+		       struct tcp_ao_counters *begin) {
>+	struct tcp_ao_counters end;
>+
>+	if (test_get_tcp_ao_counters(sk, &end))
>+		test_error("test_get_tcp_ao_counters()");
>+	verify_keys(tst_name, sk, false, true);
>+
>+	synchronize_threads(); /* 4: verified => closed */
>+	close(sk);
>+
>+	verify_counters(tst_name, true, false, begin, &end);

Shouldn't it be reversed instead?
verify_counters(tst_name, false, true, begin, &end);
The sk is an accept socket and the function is called by the server.

>+	synchronize_threads(); /* 5: counters */ }
>+
>+int main(int argc, char *argv[])
>+{
>+	test_init(120, server_fn, client_fn);
>+	return 0;
>+}
>
>--
>2.43.0