linux-kernel - Re: [PATCH v5] arm64: dts: qcom: qcm6490-idp: Add definition for three LEDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6c29ce72-e303-406a-bb75-5b36b0cd8ee4@linaro.org>
Date: Mon, 15 Jan 2024 11:26:29 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: hui liu <quic_huliu@...cinc.com>,
 Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Cc: Andy Gross <agross@...nel.org>, Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konrad.dybcio@...aro.org>, Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>, linux-arm-msm@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5] arm64: dts: qcom: qcm6490-idp: Add definition for
 three LEDs

On 15/01/2024 11:18, hui liu wrote:
> 
> 
> On 1/15/2024 5:56 PM, Dmitry Baryshkov wrote:
>> On Mon, 15 Jan 2024 at 11:48, Hui Liu via B4 Relay
>> <devnull+quic_huliu.quicinc.com@...nel.org> wrote:
>>>
>>> From: Hui Liu <quic_huliu@...cinc.com>
>>>
>>> Add definition for three LEDs to make sure they can
>>> be enabled base on QCOM LPG LED driver.
>>
>> The "function" property is still placed incorrectly. Posting the next
>> iteration before concluding the discussion on the previous one is not
>> the best idea.
> Do you mean I should update it as below? Seems there is no consumer to 
> use the function config, do we need to add now?

Paste the output of dtbs_check for your board (or CHECK_DTBS=y for your
Makefile target).

Best regards,
Krzysztof