[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240115112255.53d5bb85@device-28.home>
Date: Mon, 15 Jan 2024 11:22:55 +0100
From: Maxime Chevallier <maxime.chevallier@...tlin.com>
To: Horatiu Vultur <horatiu.vultur@...rochip.com>
Cc: <andrew@...n.ch>, <hkallweit1@...il.com>, <linux@...linux.org.uk>,
<davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
<pabeni@...hat.com>, <richardcochran@...il.com>,
<Divya.Koppera@...rochip.com>, <netdev@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <UNGLinuxDriver@...rochip.com>
Subject: Re: [PATCH net 2/2] net: micrel: Fix set/get PHC time for lan8814
Hello Horatiu,
On Sat, 13 Jan 2024 14:15:21 +0100
Horatiu Vultur <horatiu.vultur@...rochip.com> wrote:
> When setting or getting PHC time, the higher bits of the second time (>32
> bits) they were ignored. Meaning that setting some time in the future like
> year 2150, it was failing to set this.
>
> The issue can be reproduced like this:
>
> # phc_ctl /dev/ptp1 set 10000000000
> phc_ctl[118.619]: set clock time to 4294967295.000000000 or Sun Feb 7 06:28:15 2106
>
> # phc_ctl /dev/ptp1 get
> phc_ctl[120.858]: clock time is 1.238620924 or Thu Jan 1 00:00:01 1970
>
> Fixes: ece19502834d ("net: phy: micrel: 1588 support for LAN8814 phy")
> Signed-off-by: Horatiu Vultur <horatiu.vultur@...rochip.com>
This looks fine to me,
Reviewed-by: Maxime Chevallier <maxime.chevallier@...tlin.com>
Thanks,
Maxime
Powered by blists - more mailing lists