linux-kernel - RE: [PATCH v2 1/2] dt-bindings: display: panel: panel-simple: Add compatible property for waveshare 7inch touchscreen panel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 16 Jan 2024 09:40:21 +0000
From: Shengyang Chen <shengyang.chen@...rfivetech.com>
To: Conor Dooley <conor@...nel.org>
CC: "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"neil.armstrong@...aro.org" <neil.armstrong@...aro.org>,
	"quic_jesszhan@...cinc.com" <quic_jesszhan@...cinc.com>, "sam@...nborg.org"
	<sam@...nborg.org>, "airlied@...il.com" <airlied@...il.com>,
	"daniel@...ll.ch" <daniel@...ll.ch>, "maarten.lankhorst@...ux.intel.com"
	<maarten.lankhorst@...ux.intel.com>, "mripard@...nel.org"
	<mripard@...nel.org>, "tzimmermann@...e.de" <tzimmermann@...e.de>,
	"robh+dt@...nel.org" <robh+dt@...nel.org>,
	"krzysztof.kozlowski+dt@...aro.org" <krzysztof.kozlowski+dt@...aro.org>,
	"conor+dt@...nel.org" <conor+dt@...nel.org>, "wahrenst@....net"
	<wahrenst@....net>, "dave.stevenson@...pberrypi.com"
	<dave.stevenson@...pberrypi.com>, "thierry.reding@...il.com"
	<thierry.reding@...il.com>, Changhuang Liang
	<changhuang.liang@...rfivetech.com>, Keith Zhao
	<keith.zhao@...rfivetech.com>, Jack Zhu <jack.zhu@...rfivetech.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2 1/2] dt-bindings: display: panel: panel-simple: Add
 compatible property for waveshare 7inch touchscreen panel

Hi, Conor

Thanks for comment.

> -----Original Message-----
> From: Conor Dooley <conor@...nel.org>
> Sent: 2024年1月10日 0:32
> To: Shengyang Chen <shengyang.chen@...rfivetech.com>
> Cc: devicetree@...r.kernel.org; dri-devel@...ts.freedesktop.org;
> neil.armstrong@...aro.org; quic_jesszhan@...cinc.com; sam@...nborg.org;
> airlied@...il.com; daniel@...ll.ch; maarten.lankhorst@...ux.intel.com;
> mripard@...nel.org; tzimmermann@...e.de; robh+dt@...nel.org;
> krzysztof.kozlowski+dt@...aro.org; conor+dt@...nel.org; wahrenst@....net;
> dave.stevenson@...pberrypi.com; thierry.reding@...il.com; Changhuang
> Liang <changhuang.liang@...rfivetech.com>; Keith Zhao
> <keith.zhao@...rfivetech.com>; Jack Zhu <jack.zhu@...rfivetech.com>;
> linux-kernel@...r.kernel.org
> Subject: Re: [PATCH v2 1/2] dt-bindings: display: panel: panel-simple: Add
> compatible property for waveshare 7inch touchscreen panel
> 
> On Tue, Jan 09, 2024 at 03:09:48PM +0800, Shengyang Chen wrote:
> > The waveshare 7" 800x480 panel is a clone of Raspberry Pi 7" 800x480
> > panel It can be drived by Raspberry Pi panel's process but it needs
> > different timing from Raspberry Pi panel. Add compatible property for it.
> >
> > Signed-off-by: Keith Zhao <keith.zhao@...rfivetech.com>
> > Signed-off-by: Shengyang Chen <shengyang.chen@...rfivetech.com>
> > ---
> >  .../devicetree/bindings/display/panel/panel-simple.yaml         | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> > b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> > index 11422af3477e..02f6b1b2ddc9 100644
> > ---
> > a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> > +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yam
> > +++ l
> > @@ -335,6 +335,8 @@ properties:
> >        - vivax,tpc9150-panel
> >          # VXT 800x480 color TFT LCD panel
> >        - vxt,vl050-8048nt-c01
> > +        # Waveshare 7" (800x480) touchscreen LCD panel
> > +      - waveshare,7inch-touchscreen
> 
> Is "7inch-touchscreen" really a specific enough identifier for this device?
> 

Referring to official website[1] and Neil's suggestion, maybe I should change to
"7inch-touchscreen-dsi-lcd" or "waveshare,7inch-dsi-sku19885" if the next patch version is needed.

[1]: https://www.waveshare.com/7inch-dsi-lcd.htm

> >          # Winstar Display Corporation 3.5" QVGA (320x240) TFT LCD panel
> >        - winstar,wf35ltiacd
> >          # Yes Optoelectronics YTC700TLAG-05-201C 7" TFT LCD panel
> > --
> > 2.17.1
> >


Best Regards,
Shengyang