linux-kernel - RE: [PATCH v2 0/2] Add waveshare 7inch touchscreen panel support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <ZQ0PR01MB106221070C17FBDE9F9507C8EF73A@ZQ0PR01MB1062.CHNPR01.prod.partner.outlook.cn>
Date: Tue, 16 Jan 2024 09:44:19 +0000
From: Shengyang Chen <shengyang.chen@...rfivetech.com>
To: Stefan Wahren <wahrenst@....net>, "neil.armstrong@...aro.org"
	<neil.armstrong@...aro.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "dri-devel@...ts.freedesktop.org"
	<dri-devel@...ts.freedesktop.org>
CC: "quic_jesszhan@...cinc.com" <quic_jesszhan@...cinc.com>,
	"sam@...nborg.org" <sam@...nborg.org>, "airlied@...il.com"
	<airlied@...il.com>, "daniel@...ll.ch" <daniel@...ll.ch>,
	"maarten.lankhorst@...ux.intel.com" <maarten.lankhorst@...ux.intel.com>,
	"mripard@...nel.org" <mripard@...nel.org>, "tzimmermann@...e.de"
	<tzimmermann@...e.de>, "robh+dt@...nel.org" <robh+dt@...nel.org>,
	"krzysztof.kozlowski+dt@...aro.org" <krzysztof.kozlowski+dt@...aro.org>,
	"conor+dt@...nel.org" <conor+dt@...nel.org>, "dave.stevenson@...pberrypi.com"
	<dave.stevenson@...pberrypi.com>, "thierry.reding@...il.com"
	<thierry.reding@...il.com>, Changhuang Liang
	<changhuang.liang@...rfivetech.com>, Keith Zhao
	<keith.zhao@...rfivetech.com>, Jack Zhu <jack.zhu@...rfivetech.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2 0/2] Add waveshare 7inch touchscreen panel support

Hi, Stefan

Thanks for your comment and suggestion.

> -----Original Message-----
> From: Stefan Wahren <wahrenst@....net>
> Sent: 2024年1月10日 1:22
> To: neil.armstrong@...aro.org; Shengyang Chen
> <shengyang.chen@...rfivetech.com>; devicetree@...r.kernel.org;
> dri-devel@...ts.freedesktop.org
> Cc: quic_jesszhan@...cinc.com; sam@...nborg.org; airlied@...il.com;
> daniel@...ll.ch; maarten.lankhorst@...ux.intel.com; mripard@...nel.org;
> tzimmermann@...e.de; robh+dt@...nel.org;
> krzysztof.kozlowski+dt@...aro.org; conor+dt@...nel.org;
> dave.stevenson@...pberrypi.com; thierry.reding@...il.com; Changhuang
> Liang <changhuang.liang@...rfivetech.com>; Keith Zhao
> <keith.zhao@...rfivetech.com>; Jack Zhu <jack.zhu@...rfivetech.com>;
> linux-kernel@...r.kernel.org
> Subject: Re: [PATCH v2 0/2] Add waveshare 7inch touchscreen panel support
> 
> Hi Neil,
> 
> Am 09.01.24 um 12:19 schrieb neil.armstrong@...aro.org:
> > Hi,
> >
> > On 09/01/2024 08:09, Shengyang Chen wrote:
> >> This patchset adds waveshare 7inch touchscreen panel support for the
> >> StarFive JH7110 SoC.
> >
> > Could you precise which SKU you're referring to ? is it 19885 =>
> > https://www.waveshare.com/7inch-dsi-lcd.htm ?
> >
> > Are you sure it requires different timings from the RPi one ? In the
> > Waveshare wiki it explicitly uses the rpi setup (vc4-kms-dsi-7inch) to
> > drive it:
> > https://www.waveshare.com/wiki/7inch_DSI_LCD
> i don't have an anser for your question, but the Raspberry Pi vendor tree use
> different timings than the Mainline kernel:
> 
> https://github.com/raspberrypi/linux/commit/222b9baa97cc4c880d040a8c6a5
> da80d6a42c8e8
> 
> Additionally the
> arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rpidsi.dtso suggests that
> it uses the Raspberry Pi 7inch, but uses the timings of
> powertip,ph800480t013-idf02 from panel-simple.
> 
> Maybe Shengyang could test these timings with the Waveshare touch. At the
> end this rely on a proper implementation on the underlying drivers.
> 
> Sorry, for adding more confusion.
> 
Thanks for suggestion.
We will try other timing from panel-simple.
Maybe we are not going to commit new panel timing patch
if we find useful timing from panel-simple to drive the panel.

> Regards
> >
> > Neil
> >
> >>
> >>
> >> changes since v1:
> >> - Rebased on tag v6.7.
> >>
> >> patch 1:
> >> - Gave up original changing.
> >> - Changed the commit message.
> >> - Add compatible in panel-simple.yaml
> >>
> >> patch 2:
> >> - Gave up original changing.
> >> - Changed the commit message.
> >> - Add new mode for the panel in panel-simple.c
> >>
> >> v1:
> >> https://patchwork.kernel.org/project/dri-devel/cover/20231124104451.4
> >> 4271-1-shengyang.chen@...rfivetech.com/
> >>
> >> Shengyang Chen (2):
> >>    dt-bindings: display: panel: panel-simple: Add compatible property
> >> for
> >>      waveshare 7inch touchscreen panel
> >>    gpu: drm: panel: panel-simple: add new display mode for waveshare
> >>      7inch touchscreen panel
> >>
> >>   .../bindings/display/panel/panel-simple.yaml  |  2 ++
> >>   drivers/gpu/drm/panel/panel-simple.c          | 28
> >> +++++++++++++++++++
> >>   2 files changed, 30 insertions(+)
> >>
> >

thanks

Best Regards,
Shengyang