linux-kernel - Re: [PATCH v2] parse: handle __cleanup_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zag2fYsyJDtDR7a6@google.com>
Date: Wed, 17 Jan 2024 12:20:13 -0800
From: Dmitry Torokhov <dmitry.torokhov@...il.com>
To: Luc Van Oostenryck <lucvoo@...nel.org>
Cc: Dan Carpenter <dan.carpenter@...aro.org>,
	Luc Van Oostenryck <luc.vanoostenryck@...il.com>,
	linux-sparse@...r.kernel.org, Peter Zijlstra <peterz@...radead.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] parse: handle __cleanup__ attribute

Hi,

On Mon, Dec 18, 2023 at 02:51:32PM +0100, Luc Van Oostenryck wrote:
> On Thu, Dec 14, 2023 at 04:20:20PM +0300, Dan Carpenter wrote:
> > Yep.  Perfect.  Thanks so much!
> 
> Pushed now.

Any chance someone is looking at making context tracking working for
code annotated as __cleanup? We already have a bunch of code using
constructs like:

	...
	guard(spinlock_irqsave)(&gpio_lock);

	if (!test_bit(FLAG_REQUESTED, &desc->flags))
		return NULL;
	...

which resuls in:

$ make C=1 W=1 drivers/gpio/gpiolib.o
  CALL    scripts/checksyscalls.sh
  DESCEND objtool
  INSTALL libsubcmd_headers
  CC      drivers/gpio/gpiolib.o
  CHECK   drivers/gpio/gpiolib.c
drivers/gpio/gpiolib.c:2359:6: warning: context imbalance in 'gpiochip_dup_line_label' - different lock contexts for basic block

and I expect we'll see more and more of this.

Thanks.

-- 
Dmitry