linux-kernel - Re: [PATCH v2] parse: handle __cleanup_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZeCOlzq6qLJtuc0O@smile.fi.intel.com>
Date: Thu, 29 Feb 2024 16:03:03 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Herve Codina <herve.codina@...tlin.com>
Cc: Luc Van Oostenryck <lucvoo@...nel.org>,
	Dan Carpenter <dan.carpenter@...aro.org>,
	Luc Van Oostenryck <luc.vanoostenryck@...il.com>,
	linux-sparse@...r.kernel.org, Peter Zijlstra <peterz@...radead.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] parse: handle __cleanup__ attribute

On Wed, Jan 17, 2024 at 12:20:13PM -0800, Dmitry Torokhov wrote:
> On Mon, Dec 18, 2023 at 02:51:32PM +0100, Luc Van Oostenryck wrote:
> > On Thu, Dec 14, 2023 at 04:20:20PM +0300, Dan Carpenter wrote:
> > > Yep.  Perfect.  Thanks so much!
> > 
> > Pushed now.
> 
> Any chance someone is looking at making context tracking working for
> code annotated as __cleanup? We already have a bunch of code using
> constructs like:
> 
> 	...
> 	guard(spinlock_irqsave)(&gpio_lock);
> 
> 	if (!test_bit(FLAG_REQUESTED, &desc->flags))
> 		return NULL;
> 	...
> 
> which resuls in:
> 
> $ make C=1 W=1 drivers/gpio/gpiolib.o
>   CALL    scripts/checksyscalls.sh
>   DESCEND objtool
>   INSTALL libsubcmd_headers
>   CC      drivers/gpio/gpiolib.o
>   CHECK   drivers/gpio/gpiolib.c
> drivers/gpio/gpiolib.c:2359:6: warning: context imbalance in 'gpiochip_dup_line_label' - different lock contexts for basic block
> 
> and I expect we'll see more and more of this.

+1 here. It's quite annoying for every Linux kernel developer in the world
(which are at least 2k of active ones).

-- 
With Best Regards,
Andy Shevchenko