[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <69875d89-651e-41ff-a1be-385dcbb15108@quicinc.com>
Date: Wed, 17 Jan 2024 10:14:35 +0800
From: Jinlong Mao <quic_jinlmao@...cinc.com>
To: Suzuki K Poulose <suzuki.poulose@....com>,
Mike Leach
<mike.leach@...aro.org>, James Clark <james.clark@....com>,
Leo Yan
<leo.yan@...aro.org>,
Alexander Shishkin
<alexander.shishkin@...ux.intel.com>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley
<conor+dt@...nel.org>,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio
<konrad.dybcio@...aro.org>,
Mathieu Poirier <mathieu.poirier@...aro.org>
CC: <coresight@...ts.linaro.org>, <linux-arm-kernel@...ts.infradead.org>,
<linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
<linux-arm-msm@...r.kernel.org>,
Tingwei Zhang <quic_tingweiz@...cinc.com>,
Yuanfang Zhang <quic_yuanfang@...cinc.com>,
Tao Zhang
<quic_taozha@...cinc.com>
Subject: Re: [PATCH v2 1/2] dt-bindings: arm: coresight: Remove pattern match
of ETE node name
On 1/16/2024 5:33 PM, Suzuki K Poulose wrote:
> On 16/01/2024 06:45, Mao Jinlong wrote:
>> Remove pattern match of ETE node name. Use ete with the number as the
>> name for ete nodes.
>>
>> Signed-off-by: Mao Jinlong <quic_jinlmao@...cinc.com>
>> ---
>> .../bindings/arm/arm,embedded-trace-extension.yaml | 6 ++----
>> 1 file changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml b/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml
>> index f725e6940993..ed78cc7ae94a 100644
>> ---
>> a/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml
>> +++
>> b/Documentation/devicetree/bindings/arm/arm,embedded-trace-extension.yaml
>> @@ -22,8 +22,6 @@ description: |
>> with any optional connection graph as per the coresight bindings.
>> properties:
>> - $nodename:
>> - pattern: "^ete([0-9a-f]+)$"
>> compatible:
>> items:
>> - const: arm,embedded-trace-extension
>> @@ -55,13 +53,13 @@ examples:
>> # An ETE node without legacy CoreSight connections
>> - |
>> - ete0 {
>> + ete-0 {
>
> Why do we need the number ? why not simply "ete" as Krzysztof suggested ?
>
Hi Suzuki & Krzysztof ,
If name all the ete nodes' name as 'ete', there will be error below when
build images.
arch/arm64/boot/dts/qcom/sm8450.dtsi:301.6-312.4: ERROR
(duplicate_node_names): /ete: Duplicate node name
arch/arm64/boot/dts/qcom/sm8450.dtsi:314.6-325.4: ERROR
(duplicate_node_names): /ete: Duplicate node name
arch/arm64/boot/dts/qcom/sm8450.dtsi:327.6-338.4: ERROR
(duplicate_node_names): /ete: Duplicate node name
arch/arm64/boot/dts/qcom/sm8450.dtsi:340.6-351.4: ERROR
(duplicate_node_names): /ete: Duplicate node name
arch/arm64/boot/dts/qcom/sm8450.dtsi:353.6-364.4: ERROR
(duplicate_node_names): /ete: Duplicate node name
arch/arm64/boot/dts/qcom/sm8450.dtsi:366.6-377.4: ERROR
(duplicate_node_names): /ete: Duplicate node name
arch/arm64/boot/dts/qcom/sm8450.dtsi:379.6-390.4: ERROR
(duplicate_node_names): /ete: Duplicate node name
Thanks
Jinlong Mao
>
>
Powered by blists - more mailing lists