linux-kernel - Re: [PATCH 1/1] dt-bindings: interrupt-controller: fsl, irqsteer: Add power-domains

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240117-deceptive-knapsack-ba9885f7b35e@spud>
Date: Wed, 17 Jan 2024 15:14:04 +0000
From: Conor Dooley <conor@...nel.org>
To: Alexander Stein <alexander.stein@...tq-group.com>
Cc: Thomas Gleixner <tglx@...utronix.de>, Rob Herring <robh+dt@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Lucas Stach <l.stach@...gutronix.de>, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] dt-bindings: interrupt-controller: fsl, irqsteer:
 Add power-domains

On Wed, Jan 17, 2024 at 08:31:26AM +0100, Alexander Stein wrote:
> Hi Conor,
> 
> Am Donnerstag, 11. Januar 2024, 17:49:03 CET schrieb Conor Dooley:
> > On Thu, Jan 11, 2024 at 09:59:54AM +0100, Alexander Stein wrote:
> > > Hi Conor,
> > > 
> > > Am Mittwoch, 10. Januar 2024, 17:09:07 CET schrieb Conor Dooley:
> > > > On Wed, Jan 10, 2024 at 10:43:38AM +0100, Alexander Stein wrote:
> > > > > Some SoC like i.MX8QXP use a power-domain for this IP add it to the
> > > > > supported proerties. Fixes the dtbs_check warning:
> > > > > freescale/imx8qxp-tqma8xqp-mba8xx.dtb: irqsteer@...00000:
> > > > > 'power-domains'
> > > > > 
> > > > >  does not match any of the regexes: 'pinctrl-[0-9]+'
> > > > > 
> > > > > from schema $id:
> > > > > http://devicetree.org/schemas/interrupt-controller/fsl,irqsteer.yaml#
> > > > > 
> > > > > Signed-off-by: Alexander Stein <alexander.stein@...tq-group.com>
> > > > > ---
> > > > > 
> > > > > Notes:
> > > > >     Please note that both the board dts and the DT node for irqsteer
> > > > >     being
> > > > >     used, are still work-in-progress.
> > > > 
> > > > The binding doesn't even support the imx8qxp's irqsteer yet, I think
> > > > this should be added alongside support for that SoC. Am I missing
> > > > something?
> > > 
> > > I'm not sure if any additional SoC support is actually needed. 'fsl,imx-
> > > irqsteer' is available and that's what I use in my WiP. Also imx8mp also
> > > just uses the generic compatible. Only imx8mq uses 'fsl,imx8m-irqsteer'.
> > Why doesn't it used "imx8mq-irqsteer"? Should it not have its own
> > soc-specific compatible?
> 
> I would assume that "fsl,imx8m-irqsteer" is for the whole i.MX8M family. I 
> don't think a soc-specific compatible is needed at all. On top I can't see any 
> difference between i.MX8M and i.MX8/i.MX8X.
> If a soc-specific compatible is preferred, fine by me. But I don't expect any 
> difference despite imx8qxp/imx8qm requiring a power-domain.

Specific imx8mq compatibles exist for a wide range of peripherals, I'm
not sure why the irqsteer would be an exception.

Cheers,
Conor.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)