linux-kernel - Re: [PATCH v2 2/3] watchdog: Add ChromeOS EC-based watchdog driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 18 Jan 2024 15:44:20 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Lukasz Majczak <lma@...omium.org>
Cc: Gwendal Grignou <gwendal@...omium.org>,
	Tzung-Bi Shih <tzungbi@...nel.org>,
	Radoslaw Biernacki <biernacki@...gle.com>,
	Wim Van Sebroeck <wim@...ux-watchdog.org>,
	Lee Jones <lee@...nel.org>, Benson Leung <bleung@...omium.org>,
	Guenter Roeck <groeck@...omium.org>,
	Krzysztof Kozlowski <krzk@...nel.org>,
	linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org,
	chrome-platform@...ts.linux.dev
Subject: Re: [PATCH v2 2/3] watchdog: Add ChromeOS EC-based watchdog driver

On Thu, Jan 18, 2024 at 07:53:23PM +0000, Lukasz Majczak wrote:
> Embedded Controller (EC) present on Chromebook devices
> can be used as a watchdog.
> Implement a driver to support it.
> 
> Signed-off-by: Lukasz Majczak <lma@...omium.org>

Nits:

> +#define CROS_EC_WATCHDOG_DEFAULT_TIME 30 /* seconds */
> +#define DRV_NAME "cros-ec-wdt-drv"

#define<space>NAME<tab>value

please, and "-drv" in the driver name is really unnecessary.

With that changed,

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

Thanks,
Guenter