linux-kernel - Re: [PATCH net v2 2/2] net: micrel: Fix set/get PHC time for lan8814

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 18 Jan 2024 16:23:53 +0100
From: Horatiu Vultur <horatiu.vultur@...rochip.com>
To: Andrew Lunn <andrew@...n.ch>
CC: <hkallweit1@...il.com>, <linux@...linux.org.uk>, <davem@...emloft.net>,
	<edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
	<richardcochran@...il.com>, <Divya.Koppera@...rochip.com>,
	<maxime.chevallier@...tlin.com>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <UNGLinuxDriver@...rochip.com>
Subject: Re: [PATCH net v2 2/2] net: micrel: Fix set/get PHC time for lan8814

The 01/18/2024 14:52, Andrew Lunn wrote:

Hi Andrew,

> 
> On Thu, Jan 18, 2024 at 09:59:16AM +0100, Horatiu Vultur wrote:
> > When setting or getting PHC time, the higher bits of the second time (>32
> > bits) they were ignored. Meaning that setting some time in the future like
> > year 2150, it was failing to set this.
> 
> Stable rules say:
> 
> It must either fix a real bug that bothers people...
> 
> Do we have users of this device in 2150?

No, and it is not like a customer raise this issue because they have
some special cases. It was me who discover it by accident and I
found it annoying not being able to do something that is that simple.
I mean, I just want to set the time and then be able to read it back.

> 
> Maybe submit this for net-next?

Anyway, I don't have strong feelings about this, if it goes to net or
net-next, I just want to fix this at some point :)

> 
>       Andrew

-- 
/Horatiu