linux-kernel - Re: [PATCH 15/45] tty: vt: pass vpar as unsigned to csi_J() and csi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8d69bac3-1230-474e-a38c-97159f47de1e@kernel.org>
Date: Fri, 19 Jan 2024 07:29:03 +0100
From: Jiri Slaby <jirislaby@...nel.org>
To: gregkh@...uxfoundation.org
Cc: linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 15/45] tty: vt: pass vpar as unsigned to csi_J() and
 csi_K()

On 18. 01. 24, 8:57, Jiri Slaby (SUSE) wrote:
> vc_data::vc_par is passed to these function and that is unsigned. So
> accept unsigned in csi_J() and csi_K().

I've just found out the parameters can be removed completely (v2 
approaching next week).

> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@...nel.org>
> ---
>   drivers/tty/vt/vt.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c
> index c00c568c11a5..4b514187ef15 100644
> --- a/drivers/tty/vt/vt.c
> +++ b/drivers/tty/vt/vt.c
> @@ -1505,7 +1505,7 @@ enum {
>   	CSI_J_FULL		= 3,
>   };
>   
> -static void csi_J(struct vc_data *vc, int vpar)
> +static void csi_J(struct vc_data *vc, unsigned int vpar)
>   {
>   	unsigned short *start;
>   	unsigned int count;
> @@ -1548,7 +1548,7 @@ enum {
>   	CSI_K_LINE			= 2,
>   };
>   
> -static void csi_K(struct vc_data *vc, int vpar)
> +static void csi_K(struct vc_data *vc, unsigned int vpar)
>   {
>   	unsigned int count;
>   	unsigned short *start = (unsigned short *)vc->vc_pos;

-- 
js
suse labs