linux-kernel - Re: [PATCH v3 3/5] perf: script: add field 'insn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 19 Jan 2024 08:29:08 +0200
From: Adrian Hunter <adrian.hunter@...el.com>
To: Changbin Du <changbin.du@...wei.com>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
 Arnaldo Carvalho de Melo <acme@...nel.org>,
 Mark Rutland <mark.rutland@....com>,
 Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
 Jiri Olsa <jolsa@...nel.org>, Namhyung Kim <namhyung@...nel.org>,
 Ian Rogers <irogers@...gle.com>, linux-kernel@...r.kernel.org,
 linux-perf-users@...r.kernel.org, Andi Kleen <ak@...ux.intel.com>,
 Thomas Richter <tmricht@...ux.ibm.com>, changbin.du@...il.com
Subject: Re: [PATCH v3 3/5] perf: script: add field 'insn_disam' to display
 mnemonic instructions

On 19/01/24 05:57, Changbin Du wrote:
> On Thu, Jan 18, 2024 at 09:49:41PM +0200, Adrian Hunter wrote:
>> On 18/01/24 06:12, Changbin Du wrote:
>>> In addition to the 'insn' field, this adds a new field 'insn_disam' to
>>> display mnemonic instructions instead of the raw code.
>>
>> 'disam' seems an unusual abbreviation, and the 'insn' part seems a bit
>> redundant.  Could this be just 'disasm' instead of 'insn_disam'?
> 
> Personally, I'd preserve the insn_ prefix. So we have two related fields 'insn'
> and 'insn_disasm'.
> 

'ip', 'sym' 'dso' are all related but do not have a common prefix.  Also
most of the field names lean towards abbreviation.