linux-kernel - Re: [PATCH v8 4/5] iommu/arm-smmu: add ACTLR data and support for SM8550

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 19 Jan 2024 15:42:12 +0530
From: Bibek Kumar Patro <quic_bibekkum@...cinc.com>
To: Konrad Dybcio <konrad.dybcio@...aro.org>, <will@...nel.org>,
        <robin.murphy@....com>, <joro@...tes.org>,
        <dmitry.baryshkov@...aro.org>, <jsnitsel@...hat.com>,
        <quic_bjorande@...cinc.com>, <mani@...nel.org>,
        <quic_eberman@...cinc.com>, <robdclark@...omium.org>,
        <u.kleine-koenig@...gutronix.de>, <robh@...nel.org>,
        <vladimir.oltean@....com>, <quic_pkondeti@...cinc.com>,
        <quic_molvera@...cinc.com>
CC: <linux-arm-msm@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
        <iommu@...ts.linux.dev>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v8 4/5] iommu/arm-smmu: add ACTLR data and support for
 SM8550



On 1/18/2024 11:28 PM, Konrad Dybcio wrote:
> 
> 
> On 1/16/24 16:04, Bibek Kumar Patro wrote:
>> Add ACTLR data table for SM8550 along with support for
>> same including SM8550 specific implementation operations.
>>
>> Signed-off-by: Bibek Kumar Patro <quic_bibekkum@...cinc.com>
>> ---
> 
> [...]
> 
>> +static const struct actlr_variant sm8550_actlr[] = {
>> +    { .io_start = 0x15000000, .actlrcfg = sm8550_apps_actlr_cfg,
>> +            .num_actlrcfg = ARRAY_SIZE(sm8550_apps_actlr_cfg) },
>> +    { .io_start = 0x03da0000, .actlrcfg = sm8550_gfx_actlr_cfg,
>> +            .num_actlrcfg = ARRAY_SIZE(sm8550_gfx_actlr_cfg) },
>> +};
> Just a nit again, but if struct definitions need to be wrapped, this looks
> better:
> 
> {
>      .io_start = 0...,
>      .aclrcfg = ...,
>      .num_actlrcfg = ARR..,
> }, {
>      .io_start = 0..,
>      .aclrcfg = ...,
>      .num_actlrcfg = ARR..,
> };
> 

Noted, will wrap this to keep each member in a new line as shown.
This looks much cleaner. Thanks for this suggestion.

Regards,
Bibek

> Konrad