linux-kernel - Re: [PATCH v1 1/2] dt-bindings: media: starfive: Match driver and yaml property names

Open Source and information security mailing list archives

Message-ID: <20240119-despair-festival-59ab2d4d896b@wendy>
Date: Fri, 19 Jan 2024 10:16:46 +0000
From: Conor Dooley <conor.dooley@...rochip.com>
To: Changhuang Liang <changhuang.liang@...rfivetech.com>
CC: Mauro Carvalho Chehab <mchehab@...nel.org>, Rob Herring
	<robh+dt@...nel.org>, Krzysztof Kozlowski
	<krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>, Emil
 Renner Berthing <kernel@...il.dk>, Paul Walmsley <paul.walmsley@...ive.com>,
	Palmer Dabbelt <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>, Jack
 Zhu <jack.zhu@...rfivetech.com>, <linux-media@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <linux-riscv@...ts.infradead.org>,
	<devicetree@...r.kernel.org>
Subject: Re: [PATCH v1 1/2] dt-bindings: media: starfive: Match driver and
 yaml property names

On Fri, Jan 19, 2024 at 02:06:38AM -0800, Changhuang Liang wrote:
> Drop some unused properties for clocks, resets and interrupts for
> StarFive JH7110 camera subsystem.

What do you mean "unused"?

Do these clocks etc exist but are not used by the driver?

Or do they not exist at all?

The two are very different!

Thanks,
Conor.

> 
> Reviewed-by: Hal Feng <hal.feng@...rfivetech.com>
> Reviewed-by: Jack Zhu <jack.zhu@...rfivetech.com>
> Signed-off-by: Changhuang Liang <changhuang.liang@...rfivetech.com>
> ---
>  .../bindings/media/starfive,jh7110-camss.yaml | 31 +++++--------------
>  1 file changed, 8 insertions(+), 23 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml b/Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml
> index c66586d90fa2..2504381058b3 100644
> --- a/Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml
> @@ -4,14 +4,14 @@
>  $id: http://devicetree.org/schemas/media/starfive,jh7110-camss.yaml#
>  $schema: http://devicetree.org/meta-schemas/core.yaml#
>  
> -title: Starfive SoC CAMSS ISP
> +title: StarFive SoC CAMSS ISP
>  
>  maintainers:
>    - Jack Zhu <jack.zhu@...rfivetech.com>
>    - Changhuang Liang <changhuang.liang@...rfivetech.com>
>  
>  description:
> -  The Starfive CAMSS ISP is a Camera interface for Starfive JH7110 SoC. It
> +  The StarFive CAMSS ISP is a Camera interface for StarFive JH7110 SoC. It
>    consists of a VIN controller (Video In Controller, a top-level control unit)
>    and an ISP.
>  
> @@ -28,26 +28,21 @@ properties:
>        - const: isp
>  
>    clocks:
> -    maxItems: 7
> +    maxItems: 3
>  
>    clock-names:
>      items:
> -      - const: apb_func
>        - const: wrapper_clk_c
> -      - const: dvp_inv
> -      - const: axiwr
> -      - const: mipi_rx0_pxl
>        - const: ispcore_2x
>        - const: isp_axi
>  
>    resets:
> -    maxItems: 6
> +    maxItems: 5
>  
>    reset-names:
>      items:
>        - const: wrapper_p
>        - const: wrapper_c
> -      - const: axird
>        - const: axiwr
>        - const: isp_top_n
>        - const: isp_top_axi
> @@ -57,7 +52,7 @@ properties:
>        - description: JH7110 ISP Power Domain Switch Controller.
>  
>    interrupts:
> -    maxItems: 4
> +    maxItems: 3
>  
>    ports:
>      $ref: /schemas/graph.yaml#/properties/ports
> @@ -125,34 +120,24 @@ examples:
>          reg = <0x19840000 0x10000>,
>                <0x19870000 0x30000>;
>          reg-names = "syscon", "isp";
> -        clocks = <&ispcrg 0>,
> -                 <&ispcrg 13>,
> -                 <&ispcrg 2>,
> -                 <&ispcrg 12>,
> -                 <&ispcrg 1>,
> +        clocks = <&ispcrg 13>,
>                   <&syscrg 51>,
>                   <&syscrg 52>;
> -        clock-names = "apb_func",
> -                      "wrapper_clk_c",
> -                      "dvp_inv",
> -                      "axiwr",
> -                      "mipi_rx0_pxl",
> +        clock-names = "wrapper_clk_c",
>                        "ispcore_2x",
>                        "isp_axi";
>          resets = <&ispcrg 0>,
>                   <&ispcrg 1>,
> -                 <&ispcrg 10>,
>                   <&ispcrg 11>,
>                   <&syscrg 41>,
>                   <&syscrg 42>;
>          reset-names = "wrapper_p",
>                        "wrapper_c",
> -                      "axird",
>                        "axiwr",
>                        "isp_top_n",
>                        "isp_top_axi";
>          power-domains = <&pwrc 5>;
> -        interrupts = <92>, <87>, <88>, <90>;
> +        interrupts = <92>, <87>, <90>;
>  
>          ports {
>              #address-cells = <1>;
> -- 
> 2.25.1
> 
> 
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives