linux-kernel - Re: [PATCH v2] net: stmmac: Wait a bit for the reset to take effect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 19 Jan 2024 11:27:38 +0100
From: Bernd Edlinger <bernd.edlinger@...mail.de>
To: Paolo Abeni <pabeni@...hat.com>,
 Alexandre Torgue <alexandre.torgue@...s.st.com>,
 Jose Abreu <joabreu@...opsys.com>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Maxime Coquelin <mcoquelin.stm32@...il.com>, netdev@...r.kernel.org,
 linux-stm32@...md-mailman.stormreply.com,
 linux-arm-kernel@...ts.infradead.org,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 Jiri Pirko <jiri@...dia.com>, Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v2] net: stmmac: Wait a bit for the reset to take effect

On 1/16/24 13:22, Paolo Abeni wrote:
> 
> A fixes tag is requires, something alike:
> 
> Fixes: <blamed commit hash> ("<blamed commit title>")
> 
> A bisection is not strictly required, you just need to be reasonably
> confident about the the culprit.
> 

Okay, I think finally I found the commit that introduced
the broken reset logic:

commit c5e4ddbdfa1134a36589c1466ed4abb85fe6f976
Author: Chen-Yu Tsai <wens@...e.org>
Date:   Fri Jan 17 21:24:41 2014 +0800

    net: stmmac: Add support for optional reset control

    The DWMAC has a reset assert line, which is used on some SoCs. Add an
    optional reset control to stmmac driver core.

    To support reset control deferred probing, this patch changes the driver
    probe function to return the actual error, instead of just -EINVAL.

    Signed-off-by: Chen-Yu Tsai <wens@...e.org>
    Signed-off-by: David S. Miller <davem@...emloft.net>

that commit moved the reset de-assert next to the stmmac_hw_init function,
without any delay in between.

So I think I can now add
Fixes c5e4ddbdfa11 ("net: stmmac: Add support for optional reset control")

> You need to include the relevant target tree into the subj prefix (in
> this case 'net').

Will do, but please clarify how exactly I need to change the subject line.

Thanks
Bernd.