linux-kernel - Re: [RFC PATCH v2] keys: update key quotas in key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <CYIZP2D9FS0N.1XY2F5VX9STEY@seitikki>
Date: Fri, 19 Jan 2024 21:10:15 +0000
From: "Jarkko Sakkinen" <jarkko@...nel.org>
To: "Luis Henriques" <lhenriques@...e.de>, "David Howells"
 <dhowells@...hat.com>, "Eric Biggers" <ebiggers@...nel.org>
Cc: <keyrings@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH v2] keys: update key quotas in key_put()

On Mon Jan 15, 2024 at 12:03 PM UTC, Luis Henriques wrote:
> Delaying key quotas update when key's refcount reaches 0 in key_put() has
> been causing some issues in fscrypt testing.  This patches fixes this test
                                                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
						This commit fixes the test

> flakiness by dealing with the quotas immediately, but leaving all the other
> clean-ups to the key garbage collector.  Unfortunately, this means that we
> also need to switch to the irq-version of the spinlock that protects quota.

The commit message fails to describe the implementation changes.

You have a motivation paragraph but you also need to add implementation
paragraph, which describes how the code changes reflect the motivation.

BR, Jarkko