linux-kernel - Re: [RFC PATCH v2] keys: update key quotas in key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87il3llh8s.fsf@suse.de>
Date: Mon, 22 Jan 2024 11:50:11 +0000
From: Luis Henriques <lhenriques@...e.de>
To: "Jarkko Sakkinen" <jarkko@...nel.org>
Cc: "David Howells" <dhowells@...hat.com>,  "Eric Biggers"
 <ebiggers@...nel.org>,  <keyrings@...r.kernel.org>,
  <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH v2] keys: update key quotas in key_put()

"Jarkko Sakkinen" <jarkko@...nel.org> writes:

> On Mon Jan 15, 2024 at 12:03 PM UTC, Luis Henriques wrote:
>> Delaying key quotas update when key's refcount reaches 0 in key_put() has
>> been causing some issues in fscrypt testing.  This patches fixes this test
>                                                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 						This commit fixes the test
>
>> flakiness by dealing with the quotas immediately, but leaving all the other
>> clean-ups to the key garbage collector.  Unfortunately, this means that we
>> also need to switch to the irq-version of the spinlock that protects quota.
>
> The commit message fails to describe the implementation changes.
>
> You have a motivation paragraph but you also need to add implementation
> paragraph, which describes how the code changes reflect the motivation.

Thank you for your feedback, Jarkko.  I'll address your comments in v3.

But before sending another rev, I'll wait a bit more, maybe David also has
some feedback on the implementation.

Cheers,
-- 
Luís