linux-kernel - Re: [PATCH v3] x86/xen: Add some null pointer checking to smp.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <26ef811d-214c-4ce4-a9f8-4fa4cfdefe29@web.de>
Date: Sat, 20 Jan 2024 15:45:11 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Kunwu Chan <chentao@...inos.cn>, xen-devel@...ts.xenproject.org,
 kernel-janitors@...r.kernel.org, Boris Ostrovsky
 <boris.ostrovsky@...cle.com>, Borislav Petkov <bp@...en8.de>,
 Dave Hansen <dave.hansen@...ux.intel.com>, "H. Peter Anvin" <hpa@...or.com>,
 Ingo Molnar <mingo@...hat.com>, Jürgen Groß
 <jgross@...e.com>, Thomas Gleixner <tglx@...utronix.de>, x86@...nel.org
Cc: kernel test robot <lkp@...el.com>, LKML <linux-kernel@...r.kernel.org>,
 Ilya Dryomov <idryomov@...il.com>, Jean Delvare <jdelvare@...e.de>,
 Jonathan Corbet <corbet@....net>
Subject: Re: [PATCH v3] x86/xen: Add some null pointer checking to smp.c

> kasprintf() returns a pointer to dynamically allocated memory
> which can be NULL upon failure. Ensure the allocation was successful
> by checking the pointer validity.

How do you think about to refer to the function name
instead of the file name in the patch subject?

…
> +++ b/arch/x86/xen/smp.c
…
> @@ -114,6 +124,8 @@ int xen_smp_intr_init(unsigned int cpu)
>
>  	return 0;
>
> + fail_mem:
> +	rc = -ENOMEM;
>   fail:
>  	xen_smp_intr_free(cpu);
>  	return rc;

Is it currently preferred to start labels in the first text column?

Regards,
Markus