[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <91af4a8c-d2e2-416f-b02e-5d69553c5998@web.de>
Date: Fri, 19 Jan 2024 11:40:48 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Kunwu Chan <chentao@...inos.cn>, xen-devel@...ts.xenproject.org,
kernel-janitors@...r.kernel.org, Boris Ostrovsky
<boris.ostrovsky@...cle.com>, Borislav Petkov <bp@...en8.de>,
Dave Hansen <dave.hansen@...ux.intel.com>, "H. Peter Anvin" <hpa@...or.com>,
Ingo Molnar <mingo@...hat.com>, Jürgen Groß
<jgross@...e.com>, Thomas Gleixner <tglx@...utronix.de>, x86@...nel.org
Cc: kernel test robot <lkp@...el.com>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] x86/xen: Add some null pointer checking to smp.c
> kasprintf() returns a pointer to dynamically allocated memory
> which can be NULL upon failure. Ensure the allocation was successful
> by checking the pointer validity.
…
> ---
> Changes in v3:
> - Remove rc initialization
> - Simply error paths by adding a new label 'fail_mem'
…
I became curious if you would like to simplify further source code places.
> +++ b/arch/x86/xen/smp.c
> @@ -65,6 +65,8 @@ int xen_smp_intr_init(unsigned int cpu)
> char *resched_name, *callfunc_name, *debug_name;
>
> resched_name = kasprintf(GFP_KERNEL, "resched%d", cpu);
> + if (!resched_name)
> + goto fail_mem;
Would you like to add a blank line after such a statement?
> per_cpu(xen_resched_irq, cpu).name = resched_name;
…
Please compare with your subsequent suggestion.
…
> @@ -101,6 +108,9 @@ int xen_smp_intr_init(unsigned int cpu)
> }
>
> callfunc_name = kasprintf(GFP_KERNEL, "callfuncsingle%d", cpu);
> + if (!callfunc_name)
> + goto fail_mem;
> +
> per_cpu(xen_callfuncsingle_irq, cpu).name = callfunc_name;
…
Regards,
Markus
Powered by blists - more mailing lists