[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <9ac4b153-2318-4d69-9771-1b3365104904@lunn.ch>
Date: Sun, 21 Jan 2024 17:35:41 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Ziyang Huang <hzyitc@...look.com>
Cc: mcoquelin.stm32@...il.com, alexandre.torgue@...s.st.com,
richardcochran@...il.com, p.zabel@...gutronix.de,
matthias.bgg@...il.com, angelogioacchino.delregno@...labora.com,
linux-kernel@...r.kernel.org,
linux-stm32@...md-mailman.stormreply.com,
linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org,
linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH 6/8] net: mdio: ipq4019: support reset control
On Sun, Jan 21, 2024 at 08:42:35PM +0800, Ziyang Huang wrote:
In this case, you need to document why the MDIO core reset controller
code does not work for you.
You are also missing the device tree binding again.
> @@ -248,6 +254,10 @@ static int ipq4019_mdio_probe(struct platform_device *pdev)
> if (IS_ERR(priv->membase))
> return PTR_ERR(priv->membase);
>
> + priv->rst = devm_reset_control_array_get_optional_exclusive(&pdev->dev);
> + if (IS_ERR(priv->rst))
> + return PTR_ERR(priv->rst);
How many resets does this MDIO controller have? Would
devm_reset_control_get_optional_exclusive() be sufficient.
Andrew
---
pw-bot: cr
Powered by blists - more mailing lists