linux-kernel - Re: Re: [PATCH] staging: rtl8723bs: remove unnecessary braces in while loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 23 Jan 2024 12:28:44 +1300
From: Hoorad Farrokh <hourrad.f@...il.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev, 
	linux-kernel@...r.kernel.org
Subject: Re: Re: [PATCH] staging: rtl8723bs: remove unnecessary braces in
 while loop

Hello,
Thanks for your comment.

> 
> This function doesn't do anything...  The name says "free_all" but it
> doesn't free anything.  I would prefer to fix this warning by adding
> a comment:
>

I didn't fully understand this part of your comment. Do you mean I should add a comment
to the while loop + my changes and submit it agian? or 
do you mean I should find a way to free things in the while loop? then submit again?

Great regards,

Hoorad.