linux-kernel - Re: [PATCH] staging: rtl8723bs: remove unnecessary braces in while loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <39fbf9df-d6da-4275-be3b-191108f94ec2@moroto.mountain>
Date: Mon, 22 Jan 2024 10:37:58 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Hoorad Farrokh <hourrad.f@...il.com>
Cc: gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: remove unnecessary braces in while
 loop

On Mon, Jan 22, 2024 at 09:01:27AM +1300, Hoorad Farrokh wrote:
> Fixed a linux coding style.
> 
> Reported by checkpath:
> 
> WARNING: braces {} are not necessary for single statement blocks
> 
> Signed-off-by: Hoorad Farrokh <hourrad.f@...il.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_sta_mgt.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c b/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c
> index 1593980d2c6a..0145c4da5ac0 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c
> @@ -127,9 +127,8 @@ void kfree_all_stainfo(struct sta_priv *pstapriv)
>  	phead = get_list_head(&pstapriv->free_sta_queue);
>  	plist = get_next(phead);
>  
> -	while (phead != plist) {
> +	while (phead != plist)
>  		plist = get_next(plist);
> -	}

This function doesn't do anything...  The name says "free_all" but it
doesn't free anything.  I would prefer to fix this warning by adding
a comment:

diff --git a/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c b/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c
index 1593980d2c6a..4f856d126517 100644
--- a/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c
+++ b/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c
@@ -129,6 +129,7 @@ void kfree_all_stainfo(struct sta_priv *pstapriv)
 
        while (phead != plist) {
                plist = get_next(plist);
+               /* FIXME: free something? */
        }
 
        spin_unlock_bh(&pstapriv->sta_hash_lock);

We can also try adding that to the KTODO list.

KTODO: why does kfree_all_stainfo() not free anything.

Perhaps there is code in the other rtl drivers which shows how this
should be done?

regards,
dan carpenter