[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <478fc1b0-aba4-4f36-bdb6-bf5fc7eb8609@tweaklogic.com>
Date: Mon, 22 Jan 2024 20:37:32 +1030
From: Subhajit Ghosh <subhajit.ghosh@...aklogic.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
Jonathan Cameron <jic23@...nel.org>, Lars-Peter Clausen <lars@...afoo.de>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Matti Vaittinen <mazziesaccount@...il.com>,
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
Marek Vasut <marex@...x.de>, Anshul Dalal <anshulusr@...il.com>,
Javier Carrasco <javier.carrasco.cruz@...il.com>
Cc: Matt Ranostay <matt@...ostay.sg>,
Stefan Windfeldt-Prytz <stefan.windfeldt-prytz@...s.com>,
linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 2/3] dt-bindings: iio: light: Avago APDS9306
On 22/1/24 20:21, Krzysztof Kozlowski wrote:
> On 21/01/2024 06:17, Subhajit Ghosh wrote:
>> Adding device tree support for APDS9306 Ambient Light Sensor.
>> Updating datasheet hyperlinks.
>> Adding interrupt definition macro and header file.
>> Adding vdd-supply property.
>
> Why? Do other devices have it?
Are you referring to vdd-supply? No, I guess, haven't checked actually.
If other devices don't have, can you suggest the best way to handle that?
>
>
>> required:
>> @@ -33,6 +37,8 @@ required:
>>
>> examples:
>> - |
>> + #include <dt-bindings/interrupt-controller/irq.h>
>> +
>> i2c {
>> #address-cells = <1>;
>> #size-cells = <0>;
>> @@ -41,7 +47,8 @@ examples:
>> compatible = "avago,apds9300";
>> reg = <0x39>;
>> interrupt-parent = <&gpio2>;
>> - interrupts = <29 8>;
>> + interrupts = <29 IRQ_TYPE_LEVEL_LOW>;
>
> Separate change.
Understood.
>
> Best regards,
> Krzysztof
>
Regards,
Subhajit Ghosh
Powered by blists - more mailing lists