linux-kernel - Re: [PATCH] ALSA: hda: Increase default bdl_pos

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 22 Jan 2024 11:21:40 +0000
From: Rui Salvaterra <rsalvaterra@...il.com>
To: Amadeusz Sławiński <amadeuszx.slawinski@...ux.intel.com>
Cc: tiwai@...e.com, linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: hda: Increase default bdl_pos_adj for Apollo Lake

Hi, Amadeusz,

On Mon, 22 Jan 2024 at 11:05, Amadeusz Sławiński
<amadeuszx.slawinski@...ux.intel.com> wrote:
>

[snipped]

> And seems like I've missed some IDs, when doing PCI IDs conversion.
> Anyway, can you use PCI_DEVICE_ID_INTEL_HDA_APL instead of 0x5a98 as it
> is self describing (no need for comment)?

Oh, of course! I would have done it if I knew we had those constants defined. :)

> And if you want more patches in kernel - convert first 0x0f04 & 0x2284
> to PCI_DEVICE_ID_INTEL_HDA_BYT & PCI_DEVICE_ID_INTEL_HDA_BSW and then do
> the above change ;)

Killing magic numbers is always a worthwhile goal. Expect a two-patch
series soon, then. ;)

Cheers,
Rui