linux-kernel - Re: [PATCH 2/2] ALSA: hda: Increase default bdl_pos

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <521ead90-0eb8-468a-a56c-557a6ae64564@linux.intel.com>
Date: Mon, 22 Jan 2024 12:51:36 +0100
From: Amadeusz Sławiński
 <amadeuszx.slawinski@...ux.intel.com>
To: Rui Salvaterra <rsalvaterra@...il.com>, tiwai@...e.com
Cc: linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] ALSA: hda: Increase default bdl_pos_adj for Apollo
 Lake

On 1/22/2024 12:45 PM, Rui Salvaterra wrote:
> Apollo Lake seems to also suffer from IRQ timing issues. After being up for ~4
> minutes, a Pentium N4200 system ends up falling back to workqueue-based IRQ
> handling:
> 
> [  208.019906] snd_hda_intel 0000:00:0e.0: IRQ timing workaround is activated
> for card #0. Suggest a bigger bdl_pos_adj.
> 
> Unfortunately, the Baytrail and Braswell workaround value of 32 samples isn't
> enough to fix the issue here. Default to 64 samples.
> 
> Signed-off-by: Rui Salvaterra <rsalvaterra@...il.com>
> ---
>   sound/pci/hda/hda_intel.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
> index 66f013ee160d..1b550c42db09 100644
> --- a/sound/pci/hda/hda_intel.c
> +++ b/sound/pci/hda/hda_intel.c
> @@ -1732,6 +1732,8 @@ static int default_bdl_pos_adj(struct azx *chip)
>   		case PCI_DEVICE_ID_INTEL_HDA_BYT:
>   		case PCI_DEVICE_ID_INTEL_HDA_BSW:
>   			return 32;
> +		case PCI_DEVICE_ID_INTEL_HDA_APL:
> +			return 64;
>   		}
>   	}
>   

Reviewed-by: Amadeusz Sławiński <amadeuszx.slawinski@...ux.intel.com>