linux-kernel - Re: [PATCH 3/3] memory: emif: Drop usage of platform_driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 23 Jan 2024 16:17:28 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
 Santosh Shilimkar <ssantosh@...nel.org>
Cc: kernel@...gutronix.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] memory: emif: Drop usage of platform_driver_probe()

On 17/12/2023 20:31, Uwe Kleine-König wrote:
> There are considerations to drop platform_driver_probe() as a concept
> that isn't relevant any more today. It comes with an added complexity
> that makes many users hold it wrong. (E.g. this driver should have
> better used __init instead of __init_or_module to mark functions only
> relevant to .probe() and mark the driver struct with __refdata.)
> 
> This fixes a W=1 build warning:
> 
> 	WARNING: modpost: drivers/memory/emif: section mismatch in reference: emif_driver+0x4 (section: .data) -> emif_remove (section: .exit.text)
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> ---
>  drivers/memory/emif.c | 23 ++++++++++++-----------

I applied #1 and #2. This does not apply. Please rebase and resend.

Best regards,
Krzysztof