[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2f3144e2-2438-4ea8-ada0-3fbdd79ee131@foss.st.com>
Date: Tue, 23 Jan 2024 17:36:12 +0100
From: Alexandre TORGUE <alexandre.torgue@...s.st.com>
To: Dario Binacchi <dario.binacchi@...rulasolutions.com>,
<linux-kernel@...r.kernel.org>
CC: <linux-amarula@...rulasolutions.com>, Lee Jones <lee@...nel.org>,
Raphael
Gallais-Pou <raphael.gallais-pou@...s.st.com>,
Linus Walleij
<linus.walleij@...aro.org>,
Andre Przywara <andre.przywara@....com>,
Baruch
Siach <baruch@...s.co.il>, Conor Dooley <conor+dt@...nel.org>,
Krzysztof
Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Leonard Göhrs
<l.goehrs@...gutronix.de>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
Peter
Rosin <peda@...ntia.se>, Rob Herring <robh+dt@...nel.org>,
Sean Nyekjaer
<sean@...nix.com>, <devicetree@...r.kernel.org>,
<linux-arm-kernel@...ts.infradead.org>,
<linux-stm32@...md-mailman.stormreply.com>
Subject: Re: [PATCH v8 5/5] ARM: dts: add
stm32f769-disco-mb1225-revb03-mb1166-reva09
Hi Dario
On 1/12/24 15:48, Dario Binacchi wrote:
> As reported in the section 8.3 (i. e. Board revision history) of document
> UM2033 (i. e. Discovery kit with STM32F769NI MCU) these are the changes
> related to the board revisions addressed by the patch:
> - Board MB1225 revision B-03:
> - Memory MICRON MT48LC4M32B2B5-6A replaced by ISSI IS42S32400F-6BL
> - Board MB1166 revision A-09:
> - LCD FRIDA FRD397B25009-D-CTK replaced by FRIDA FRD400B25025-A-CTK
>
> The patch only adds the DTS support for the new display which belongs to
> to the Novatek NT35510-based panel family.
>
> Signed-off-by: Dario Binacchi <dario.binacchi@...rulasolutions.com>
> Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
> Reviewed-by: Raphael Gallais-Pou <raphael.gallais-pou@...s.st.com>
>
I still have YAML error. Do you have same on your side or maybe I missed
a dt-binding patch somewhere ?
/arch/arm/boot/dts/st/stm32f769-disco-mb1225-revb03-mb1166-reva09.dtb:
dsi@...16c00: Unevaluated properties are not allowed ('interrupts',
'panel-dsi@0' were unexpected)
from schema $id: http://devicetree.org/schemas/display/st,stm32-dsi.yaml#
/arch/arm/boot/dts/st/stm32f769-disco-mb1225-revb03-mb1166-reva09.dtb:
panel-dsi@0: 'port' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id:
http://devicetree.org/schemas/display/panel/novatek,nt35510.yaml#
Aside that, I just have a cosmetic question. Can we find a shorter name
for the board ? (not sure we can).
Cheers
Alex
> ---
>
> Changes in v8:
> - Add Reviewed-by tag of Linus Walleij
> - Add Reviewed-by tag of Raphael Gallais-Pou
>
> Changes in v7:
> - Replace .dts with .dtb in the Makefile
>
> Changes in v6:
> - Drop patches
> - [5/8] dt-bindings: nt35510: add compatible for FRIDA FRD400B25025-A-CTK
> - [7/8] drm/panel: nt35510: move hardwired parameters to configuration
> - [8/8] drm/panel: nt35510: support FRIDA FRD400B25025-A-CTK
> because applied by the maintainer Linus Walleij
>
> Changes in v5:
> - Replace GPIOD_ASIS with GPIOD_OUT_HIGH in the call to devm_gpiod_get_optional().
>
> Changes in v2:
> - Change the status of panel_backlight node to "disabled"
> - Delete backlight property from panel0 node.
> - Re-write the patch [8/8] "drm/panel: nt35510: support FRIDA FRD400B25025-A-CTK"
> in the same style as the original driver.
>
> arch/arm/boot/dts/st/Makefile | 1 +
> ...2f769-disco-mb1225-revb03-mb1166-reva09.dts | 18 ++++++++++++++++++
> 2 files changed, 19 insertions(+)
> create mode 100644 arch/arm/boot/dts/st/stm32f769-disco-mb1225-revb03-mb1166-reva09.dts
>
> diff --git a/arch/arm/boot/dts/st/Makefile b/arch/arm/boot/dts/st/Makefile
> index 7892ad69b441..aa5b50d7ac61 100644
> --- a/arch/arm/boot/dts/st/Makefile
> +++ b/arch/arm/boot/dts/st/Makefile
> @@ -23,6 +23,7 @@ dtb-$(CONFIG_ARCH_STM32) += \
> stm32f469-disco.dtb \
> stm32f746-disco.dtb \
> stm32f769-disco.dtb \
> + stm32f769-disco-mb1225-revb03-mb1166-reva09.dtb \
> stm32429i-eval.dtb \
> stm32746g-eval.dtb \
> stm32h743i-eval.dtb \
> diff --git a/arch/arm/boot/dts/st/stm32f769-disco-mb1225-revb03-mb1166-reva09.dts b/arch/arm/boot/dts/st/stm32f769-disco-mb1225-revb03-mb1166-reva09.dts
> new file mode 100644
> index 000000000000..014cac192375
> --- /dev/null
> +++ b/arch/arm/boot/dts/st/stm32f769-disco-mb1225-revb03-mb1166-reva09.dts
> @@ -0,0 +1,18 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (c) 2023 Dario Binacchi <dario.binacchi@...rulasolutions.com>
> + */
> +
> +#include "stm32f769-disco.dts"
> +
> +&panel_backlight {
> + status = "disabled";
> +};
> +
> +&panel0 {
> + compatible = "frida,frd400b25025", "novatek,nt35510";
> + vddi-supply = <&vcc_3v3>;
> + vdd-supply = <&vcc_3v3>;
> + /delete-property/backlight;
> + /delete-property/power-supply;
> +};
Powered by blists - more mailing lists