linux-kernel - Re: [PATCH v8 3/5] ARM: dts: stm32: rename mmc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABGWkvqDX5czR+2zsH0aStPt5nbDLU_45rDDjGawKFH23e4FQg@mail.gmail.com>
Date: Tue, 23 Jan 2024 19:27:23 +0100
From: Dario Binacchi <dario.binacchi@...rulasolutions.com>
To: Alexandre TORGUE <alexandre.torgue@...s.st.com>
Cc: linux-kernel@...r.kernel.org, linux-amarula@...rulasolutions.com, 
	Lee Jones <lee@...nel.org>, Raphael Gallais-Pou <raphael.gallais-pou@...s.st.com>, 
	Conor Dooley <conor+dt@...nel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, 
	Maxime Coquelin <mcoquelin.stm32@...il.com>, Rob Herring <robh+dt@...nel.org>, 
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-stm32@...md-mailman.stormreply.com
Subject: Re: [PATCH v8 3/5] ARM: dts: stm32: rename mmc_vcard to vcc-3v3 on stm32f769-disco

Hi Alexandre,

On Tue, Jan 23, 2024 at 5:31 PM Alexandre TORGUE
<alexandre.torgue@...s.st.com> wrote:
>
> Hi Dario
>
> On 1/12/24 15:48, Dario Binacchi wrote:
> > In the schematics of document UM2033, the power supply for the micro SD
> > card is the same 3v3 voltage that is used to power other devices on the
> > board. By generalizing the name of the voltage regulator, it can be
> > referenced by other nodes in the device tree without creating
> > misunderstandings.
> >
> > This patch is preparatory for future developments.
> >
> > Signed-off-by: Dario Binacchi <dario.binacchi@...rulasolutions.com>
> > Reviewed-by: Raphael Gallais-Pou <raphael.gallais-pou@...s.st.com>
> >
> > ---
> >
> > Changes in v8:
> > - Add Reviewed-by tag of Raphael Gallais-Pou
> >
> >   arch/arm/boot/dts/st/stm32f769-disco.dts | 6 +++---
> >   1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/st/stm32f769-disco.dts b/arch/arm/boot/dts/st/stm32f769-disco.dts
> > index 5d12ae25b327..8632bd866272 100644
> > --- a/arch/arm/boot/dts/st/stm32f769-disco.dts
> > +++ b/arch/arm/boot/dts/st/stm32f769-disco.dts
> > @@ -92,9 +92,9 @@ usbotg_hs_phy: usb-phy {
> >               clock-names = "main_clk";
> >       };
> >
> > -     mmc_vcard: mmc_vcard {
> > +     vcc_3v3: vcc_3v3 {
>
> Replace node name by vcc-3v3. If no v9 sent, I'll do it directly.

I'll do it

Thanks and regards,
Dario

>
> >               compatible = "regulator-fixed";
> > -             regulator-name = "mmc_vcard";
> > +             regulator-name = "vcc_3v3";
> >               regulator-min-microvolt = <3300000>;
> >               regulator-max-microvolt = <3300000>;
> >       };
> > @@ -128,7 +128,7 @@ &rtc {
> >
> >   &sdio2 {
> >       status = "okay";
> > -     vmmc-supply = <&mmc_vcard>;
> > +     vmmc-supply = <&vcc_3v3>;
> >       cd-gpios = <&gpioi 15 GPIO_ACTIVE_LOW>;
> >       broken-cd;
> >       pinctrl-names = "default", "opendrain", "sleep";



-- 

Dario Binacchi

Senior Embedded Linux Developer

dario.binacchi@...rulasolutions.com

__________________________________


Amarula Solutions SRL

Via Le Canevare 30, 31100 Treviso, Veneto, IT

T. +39 042 243 5310
info@...rulasolutions.com

www.amarulasolutions.com