linux-kernel - Re: [PATCH v2 16/20] dt-bindings: crypto: meson: add new compatibles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 23 Jan 2024 12:37:31 -0600
From: Rob Herring <robh@...nel.org>
To: Alexey Romanov <avromanov@...utedevices.com>
Cc: neil.armstrong@...aro.org, clabbe@...libre.com, khilman@...libre.com, 
 davem@...emloft.net, linux-crypto@...r.kernel.org, 
 linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org, 
 kernel@...utedevices.com, linux-arm-kernel@...ts.infradead.org, 
 devicetree@...r.kernel.org, conor+dt@...nel.org, 
 herbert@...dor.apana.org.au, jbrunet@...libre.com, 
 martin.blumenstingl@...glemail.com, krzysztof.kozlowski+dt@...aro.org, 
 robh+dt@...nel.org
Subject: Re: [PATCH v2 16/20] dt-bindings: crypto: meson: add new
 compatibles


On Tue, 23 Jan 2024 19:58:27 +0300, Alexey Romanov wrote:
> Now we can use crypto driver at G12A/G12B/S4/A1/SM1/AXG.
> 
> Signed-off-by: Alexey Romanov <avromanov@...utedevices.com>
> ---
>  .../bindings/crypto/amlogic,gxl-crypto.yaml   | 31 ++++++++++++++++---
>  1 file changed, 27 insertions(+), 4 deletions(-)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.example.dtb: crypto-engine@...3e000: compatible: 'oneOf' conditional failed, one must be fixed:
	['amlogic,gxl-crypto'] is too short
	'amlogic,gxl-crypto' is not one of ['amlogic,g12a-crypto', 'amlogic,s4-crypto', 'amlogic,a1-crypto']
	from schema $id: http://devicetree.org/schemas/crypto/amlogic,gxl-crypto.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240123165831.970023-17-avromanov@salutedevices.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.