linux-kernel - Re: [PATCH v2 16/20] dt-bindings: crypto: meson: add new compatibles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 24 Jan 2024 08:22:27 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Alexey Romanov <avromanov@...utedevices.com>, neil.armstrong@...aro.org,
 clabbe@...libre.com, herbert@...dor.apana.org.au, davem@...emloft.net,
 robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
 khilman@...libre.com, jbrunet@...libre.com,
 martin.blumenstingl@...glemail.com
Cc: linux-crypto@...r.kernel.org, linux-amlogic@...ts.infradead.org,
 linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, kernel@...utedevices.com
Subject: Re: [PATCH v2 16/20] dt-bindings: crypto: meson: add new compatibles

On 23/01/2024 17:58, Alexey Romanov wrote:
> Now we can use crypto driver at G12A/G12B/S4/A1/SM1/AXG.
> 
> Signed-off-by: Alexey Romanov <avromanov@...utedevices.com>
> ---
>  .../bindings/crypto/amlogic,gxl-crypto.yaml   | 31 ++++++++++++++++---
>  1 file changed, 27 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml b/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml
> index 948e11ebe4ee..a7145b126a06 100644
> --- a/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml
> +++ b/Documentation/devicetree/bindings/crypto/amlogic,gxl-crypto.yaml
> @@ -11,8 +11,15 @@ maintainers:
>  
>  properties:
>    compatible:
> -    items:
> -      - const: amlogic,gxl-crypto
> +    oneOf:
> +      - items:

That's just enum.

> +          - enum:
> +              - amlogic,g12a-crypto
> +              - amlogic,s4-crypto
> +              - amlogic,a1-crypto
> +      - items:
> +          - const: amlogic,gxl-crypto
> +          - const: amlogic,axg-crypto

This is neither explained nor correct. You just affected all DTS.

>  
>    reg:
>      maxItems: 1
> @@ -32,8 +39,24 @@ required:
>    - compatible
>    - reg
>    - interrupts
> -  - clocks
> -  - clock-names
> +
> +if:

Missing allOf

> +  properties:
> +    compatible:
> +      contains:
> +        enum:
> +          - amlogic,gxl-crypto
> +then:
> +  required:
> +    - clocks
> +    - clock-names

Why? Also not explained.

Entire patch was not tested and it unexpectedly affects/changes existing
bindings without explanation in commit msg.



Best regards,
Krzysztof