linux-kernel - Re: [PATCH] drm: apple: mark local functions static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <489e3e5d-25e7-4e84-9e62-b6e52bf7455c@app.fastmail.com>
Date: Tue, 23 Jan 2024 19:51:23 +0100
From: "Janne Grunau" <j@...nau.net>
To: "Arnd Bergmann" <arnd@...db.de>, "Arnd Bergmann" <arnd@...nel.org>,
 "Alyssa Rosenzweig" <alyssa@...enzweig.io>,
 Martin Povišer <povik+lin@...ebit.org>
Cc: asahi@...ts.linux.dev, "Hector Martin" <marcan@...can.st>,
 "Sven Peter" <sven@...npeter.dev>, "Asahi Lina" <lina@...hilina.net>,
 dri-devel@...ts.freedesktop.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm: apple: mark local functions static

Hej Arnd,

On Tue, Jan 23, 2024, at 08:34, Arnd Bergmann wrote:
> On Mon, Jan 22, 2024, at 21:50, Janne Grunau wrote:
>> On Wed, Jan 17, 2024, at 11:44, Arnd Bergmann wrote:
>>> 
>>> -int parse_sample_rate_bit(struct dcp_parse_ctx *handle, unsigned int 
>>> *ratebit)
>>> +static int parse_sample_rate_bit(struct dcp_parse_ctx *handle, 
>>> unsigned int *ratebit)
>>>  {
>>>  	s64 rate;
>>>  	int ret = parse_int(handle, &rate);
>>> @@ -715,7 +715,7 @@ int parse_sample_rate_bit(struct dcp_parse_ctx 
>>> *handle, unsigned int *ratebit)
>>>  	return 0;
>>>  }
>>> 
>>> -int parse_sample_fmtbit(struct dcp_parse_ctx *handle, u64 *fmtbit)
>>> +static int parse_sample_fmtbit(struct dcp_parse_ctx *handle, u64 *fmtbit)
>>>  {
>>>  	s64 sample_size;
>>>  	int ret = parse_int(handle, &sample_size);
>>
>> thanks, patch included in my dev branch and will be in the next pull 
>> request I'll send to Hector.
>>
>> I suppose the recipients are generated by an automated 
>> get_maintainers.pl invocation. Is that desired for out of tree drivers?
>
> I was wondering about that as well, as I don't usually send
> patches for code that isn't at least in linux-next yet.
>
> I ended up using what is in the MAINTAINERS file for this driver
> in the branch as that is is all I have at this point:
>
> APPLE DRM DISPLAY DRIVER
> M:      Alyssa Rosenzweig <alyssa@...enzweig.io>
> L:      dri-devel@...ts.freedesktop.org
> S:      Maintained
> T:      git git://anongit.freedesktop.org/drm/drm-misc
> F:      drivers/gpu/drm/apple/
>
> I left out the drivers/gpu/ maintainer addresses though.

oops, answered to the wrong patch. The strscpy one has the drivers/gpu/ maintainers and the question. I replied here first assuming it has the same recipient list. I'd consider the recipients for this mail reasonable.

Janne