linux-kernel - Re: [v2 4/4] KVM: s390: don't setup dummy routing when KVM_CREATE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAN35MuR-t0THwSQa5ye8inLon3hMCZiHWnu5ofVNxmPJQ6+izg@mail.gmail.com>
Date: Wed, 24 Jan 2024 10:16:15 +0800
From: Yi Wang <up2wing@...il.com>
To: Oliver Upton <oliver.upton@...ux.dev>
Cc: seanjc@...gle.com, pbonzini@...hat.com, tglx@...utronix.de, 
	mingo@...hat.com, bp@...en8.de, dave.hansen@...ux.intel.com, x86@...nel.org, 
	hpa@...or.com, kvm@...r.kernel.org, linux-kernel@...r.kernel.org, 
	wanpengli@...cent.com, foxywang@...cent.com, maz@...nel.org, 
	anup@...infault.org, atishp@...shpatra.org, borntraeger@...ux.ibm.com, 
	frankja@...ux.ibm.com, imbrenda@...ux.ibm.com
Subject: Re: [v2 4/4] KVM: s390: don't setup dummy routing when KVM_CREATE_IRQCHIP

On Wed, Jan 24, 2024 at 2:54 AM Oliver Upton <oliver.upton@...ux.dev> wrote:
>
> On Sun, Jan 21, 2024 at 07:17:30PM +0800, Yi Wang wrote:
> > As we have setup empty irq routing in kvm_create_vm(), there's
> > no need to setup dummy routing when KVM_CREATE_IRQCHIP.
> >
> > Signed-off-by: Yi Wang <foxywang@...cent.com>
> > ---
> >  arch/s390/kvm/kvm-s390.c | 13 +++++--------
> >  1 file changed, 5 insertions(+), 8 deletions(-)
> >
> > diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
> > index acc81ca6492e..7c836c973b75 100644
> > --- a/arch/s390/kvm/kvm-s390.c
> > +++ b/arch/s390/kvm/kvm-s390.c
> > @@ -2999,14 +2999,11 @@ int kvm_arch_vm_ioctl(struct file *filp, unsigned int ioctl, unsigned long arg)
> >               break;
> >       }
> >       case KVM_CREATE_IRQCHIP: {
> > -             struct kvm_irq_routing_entry routing;
> > -
> > -             r = -EINVAL;
> > -             if (kvm->arch.use_irqchip) {
> > -                     /* Set up dummy routing. */
> > -                     memset(&routing, 0, sizeof(routing));
> > -                     r = kvm_set_irq_routing(kvm, &routing, 0, 0);
> > -             }
> > +             /*
> > +              * As we have set up empty routing, there is no need to
> > +              * setup dummy routing here.
> > +              */
>
> Where exactly?
>
> In the context of this patch series it is rather obvious, but this
> comment does not stand on its own. You can either throw the reader a
> bone by mentioning where the dummy routing is created or just drop the
> comment altogether.

Yeap, you are right. I will drop this in the upcoming patch.

>
> > +             r = 0;
> >               break;
> >       }
> >       case KVM_SET_DEVICE_ATTR: {
> > --
> > 2.39.3
> >
>
> --
> Thanks,
> Oliver



-- 
---
Best wishes
Yi Wang