linux-kernel - Re: [v2 1/4] KVM: irqchip: add setup empty irq routing function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAN35MuRwrQ3D6TZLsE0a0zKqRajpB9vfonxm9dQX67wSV0i84g@mail.gmail.com>
Date: Wed, 24 Jan 2024 10:12:03 +0800
From: Yi Wang <up2wing@...il.com>
To: Oliver Upton <oliver.upton@...ux.dev>
Cc: seanjc@...gle.com, pbonzini@...hat.com, tglx@...utronix.de, 
	mingo@...hat.com, bp@...en8.de, dave.hansen@...ux.intel.com, x86@...nel.org, 
	hpa@...or.com, kvm@...r.kernel.org, linux-kernel@...r.kernel.org, 
	wanpengli@...cent.com, foxywang@...cent.com, maz@...nel.org, 
	anup@...infault.org, atishp@...shpatra.org, borntraeger@...ux.ibm.com, 
	frankja@...ux.ibm.com, imbrenda@...ux.ibm.com
Subject: Re: [v2 1/4] KVM: irqchip: add setup empty irq routing function

On Wed, Jan 24, 2024 at 2:47 AM Oliver Upton <oliver.upton@...ux.dev> wrote:
>
> On Sun, Jan 21, 2024 at 07:17:27PM +0800, Yi Wang wrote:
> > Add a new function to setup empty irq routing in kvm path, which
> > can be invoded in non-architecture-specific functions. The difference
> > compared to the kvm_setup_empty_irq_routing() is this function just
> > alloc the empty irq routing and does not need synchronize srcu, as
> > we will call it in kvm_create_vm().
> >
> > This patch is a preparatory step for an upcoming patch to avoid
> > delay in KVM_CAP_SPLIT_IRQCHIP ioctl.
>
> Adding a function in a separate patch from its callsites is never
> useful. Please squash this into the second patch.

Thanks for your review and suggestion. I will update this patch ASAP.

>
> --
> Thanks,
> Oliver



-- 
---
Best wishes
Yi Wang