linux-kernel - Re: [PATCH] dt-bindings: pinctr: pinctrl-zynq: Fix compatible string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 24 Jan 2024 16:16:12 +0000
From: Conor Dooley <conor@...nel.org>
To: Michal Simek <michal.simek@....com>
Cc: linux-kernel@...r.kernel.org, monstr@...str.eu, michal.simek@...inx.com,
	git@...inx.com, Conor Dooley <conor+dt@...nel.org>,
	Krishna Potthuri <sai.krishna.potthuri@....com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Rob Herring <robh+dt@...nel.org>,
	Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@...inx.com>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>,
	"moderated list:ARM/ZYNQ ARCHITECTURE" <linux-arm-kernel@...ts.infradead.org>,
	"open list:PIN CONTROL SUBSYSTEM" <linux-gpio@...r.kernel.org>
Subject: Re: [PATCH] dt-bindings: pinctr: pinctrl-zynq: Fix compatible string

On Wed, Jan 24, 2024 at 10:07:46AM +0100, Michal Simek wrote:
> Compatible string doesn't really match with compatible string listed in the
> driver itself. While binding was converted from txt to yaml
> xlnx,zynq-pinctrl was listed as compatible string but example was using
> xlnx,pinctrl-zynq and also this string is used in all DTSes.
> xlnx,zynq-pinctrl is used only in dt binding and not present in any DT
> which is stable for quite a long time that's why use old compatible string
> and update binding document instead of starting to use unused compatible
> string.
> 
> Fixes: 153df45acda0 ("dt-bindings: pinctrl: pinctrl-zynq: Convert to yaml")
> Signed-off-by: Michal Simek <michal.simek@....com>

I assume that U-Boot etc all use the "incorrect" compatible as was in
the example? If they do, then the patch seems good to me.

Thanks,
Conor.

> ---
> 
>  .../{xlnx,zynq-pinctrl.yaml => xlnx,pinctrl-zynq.yaml}      | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>  rename Documentation/devicetree/bindings/pinctrl/{xlnx,zynq-pinctrl.yaml => xlnx,pinctrl-zynq.yaml} (98%)
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/xlnx,zynq-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/xlnx,pinctrl-zynq.yaml
> similarity index 98%
> rename from Documentation/devicetree/bindings/pinctrl/xlnx,zynq-pinctrl.yaml
> rename to Documentation/devicetree/bindings/pinctrl/xlnx,pinctrl-zynq.yaml
> index d2676f92ef5b..de6c10ba36c4 100644
> --- a/Documentation/devicetree/bindings/pinctrl/xlnx,zynq-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/xlnx,pinctrl-zynq.yaml
> @@ -1,7 +1,7 @@
>  # SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
>  %YAML 1.2
>  ---
> -$id: http://devicetree.org/schemas/pinctrl/xlnx,zynq-pinctrl.yaml#
> +$id: http://devicetree.org/schemas/pinctrl/xlnx,pinctrl-zynq.yaml#
>  $schema: http://devicetree.org/meta-schemas/core.yaml#
>  
>  title: Xilinx Zynq Pinctrl
> @@ -28,7 +28,7 @@ description: |
>  
>  properties:
>    compatible:
> -    const: xlnx,zynq-pinctrl
> +    const: xlnx,pinctrl-zynq
>  
>    reg:
>      description: Specifies the base address and size of the SLCR space.
> @@ -181,7 +181,7 @@ examples:
>    - |
>      #include <dt-bindings/pinctrl/pinctrl-zynq.h>
>      pinctrl0: pinctrl@700 {
> -       compatible = "xlnx,zynq-pinctrl";
> +       compatible = "xlnx,pinctrl-zynq";
>         reg = <0x700 0x200>;
>         syscon = <&slcr>;
>  
> -- 
> 2.36.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)