linux-kernel - Re: [PATCH] dt-bindings: pinctr: pinctrl-zynq: Fix compatible string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5f2e3917-4767-48ca-9217-fc51fb181daa@amd.com>
Date: Thu, 25 Jan 2024 08:06:35 +0100
From: Michal Simek <michal.simek@....com>
To: Conor Dooley <conor@...nel.org>
Cc: linux-kernel@...r.kernel.org, monstr@...str.eu, michal.simek@...inx.com,
 git@...inx.com, Conor Dooley <conor+dt@...nel.org>,
 Krishna Potthuri <sai.krishna.potthuri@....com>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Linus Walleij <linus.walleij@...aro.org>, Rob Herring <robh+dt@...nel.org>,
 Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@...inx.com>,
 "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
 <devicetree@...r.kernel.org>,
 "moderated list:ARM/ZYNQ ARCHITECTURE"
 <linux-arm-kernel@...ts.infradead.org>,
 "open list:PIN CONTROL SUBSYSTEM" <linux-gpio@...r.kernel.org>
Subject: Re: [PATCH] dt-bindings: pinctr: pinctrl-zynq: Fix compatible string



On 1/24/24 17:16, Conor Dooley wrote:
> On Wed, Jan 24, 2024 at 10:07:46AM +0100, Michal Simek wrote:
>> Compatible string doesn't really match with compatible string listed in the
>> driver itself. While binding was converted from txt to yaml
>> xlnx,zynq-pinctrl was listed as compatible string but example was using
>> xlnx,pinctrl-zynq and also this string is used in all DTSes.
>> xlnx,zynq-pinctrl is used only in dt binding and not present in any DT
>> which is stable for quite a long time that's why use old compatible string
>> and update binding document instead of starting to use unused compatible
>> string.
>>
>> Fixes: 153df45acda0 ("dt-bindings: pinctrl: pinctrl-zynq: Convert to yaml")
>> Signed-off-by: Michal Simek <michal.simek@....com>
> 
> I assume that U-Boot etc all use the "incorrect" compatible as was in
> the example? If they do, then the patch seems good to me.

Yes. U-Boot is using "incorrect" compatible string from 2015.

Thanks,
Michal